Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <c497b3055c49733a10a25e0356090d593874e2ea.camel@kernel.org>
Subject: Re: [PATCH] tpm: tis: Kconfig: Add helper dependency on COMPILE_TEST
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Cai Huoqing <caihuoqing@baidu.com>, peterhuewe@gmx.de, jgg@ziepe.ca
Cc:     linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 26 Aug 2021 01:20:18 +0300
In-Reply-To: <20210825062617.2435-1-caihuoqing@baidu.com>
References: <20210825062617.2435-1-caihuoqing@baidu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2021-08-25 at 14:26 +0800, Cai Huoqing wrote:
> it's helpful for complie test in other platform(e.g.X86)

You need to write a proper long description, starting from that
sentences start with capital letter and end with a period.

What is "it"?


> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
>  drivers/char/tpm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index d6ba644f6b00..4a5516406c22 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -76,7 +76,7 @@ config TCG_TIS_SPI_CR50
> =20
>  config TCG_TIS_SYNQUACER
>  	tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Inte=
rface (MMIO - SynQuacer)"
> -	depends on ARCH_SYNQUACER
> +	depends on ARCH_SYNQUACER || COMPILE_TEST
>  	select TCG_TIS_CORE
>  	help
>  	  If you have a TPM security chip that is compliant with the

/Jarkko