Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp44681pxb; Wed, 25 Aug 2021 19:30:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdTsgy3ZB1qcgHzq8QGlHe92COQMbfBVhlrDou5WoE/EtgLKQtGlytXu43gYYzqoB22Iza X-Received: by 2002:a17:906:1701:: with SMTP id c1mr1731239eje.425.1629945017062; Wed, 25 Aug 2021 19:30:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629945017; cv=none; d=google.com; s=arc-20160816; b=gv8DBsO8q9WWfLymJ4T+n0Rdj/DCulun2xF2YkumoLCoN2ajzbP+FVOYcVY6NzB6s4 XmcUnyrUkM99gcJk/vHuMflJ9cbFBQ8haoPdp8PdVAL6EYDjZEcfuDDeO6IWERl/lTeT yLgWckIHDqMrcO77vFqw2zwocHn09mnmfYe5GQGtq3roaCn0RDGDRq3mvYsU+GnEFC9r NMxdZDNwyKrSjw7KfWGa9ftUUoCcn1QuSmr/9pc4Has3tvBU2pF4ZUJxd1slmCwrdH9Y gwkyT6BTD8wYtUtyrSTCLWuf6vvzz7iw8yYclpf6R/DCbw3+PRwGprvekOTWPrcrT+1A GX2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from; bh=5x9O19UUWMPFwiBDXD+U3mf1ng52+rFif+SbaAaCRts=; b=0iVDfHYKypxX1AIYNdaLIhF179KheDyCELGUrMBh2r1cs2DbtpexTkFqyooNjbCg1j NaIIRVN4q5sCtrMUMzvTUIDWPB5iizJS+r6ysHkmm2+NKBx7nyaIuFAOlyQ3TzgxzeDt tt5Zn1zIlb3GgmCYwiQXIlL5QdEWFRNr7tsuQXNiH1vIMFpfvO9BrjZOCwzOH0TeqLFh f+yc+O7d5sPYiouxF/bwkIoqICzelphVqwVv+bQpQEnsYsvKO80iO+SvXGd3ueMMG2ry nzxy+fkzvojP05SYeqWepCObMQdGyZIL5anbh5N8o3iUYW+KC5jraBAxz/m7Q3A8H+zd JPvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k1si1503236ejx.491.2021.08.25.19.29.53; Wed, 25 Aug 2021 19:30:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237521AbhHZCY1 (ORCPT + 99 others); Wed, 25 Aug 2021 22:24:27 -0400 Received: from smtpbgsg1.qq.com ([54.254.200.92]:57679 "EHLO smtpbgsg1.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235677AbhHZCY0 (ORCPT ); Wed, 25 Aug 2021 22:24:26 -0400 X-QQ-mid: bizesmtp47t1629944600t0qbyafz Received: from localhost.localdomain (unknown [111.207.172.18]) by esmtp6.qq.com (ESMTP) with id ; Thu, 26 Aug 2021 10:23:17 +0800 (CST) X-QQ-SSF: 0140000000200050D000B00A0000000 X-QQ-FEAT: zEFwFsE0FwpIbzN/rQ0seBiGJYh4ez3wZarFkHyzKOOMPDaKXKPVZqZhm5b0y t00/pnVZyX/ysLQOnp7WOI4rsTD+SO4sJTbUI9ENNNpbyob2XS4/h7JPro0WSxF3ZsXsQAw rl7IFbMAYbicqOR0tH8vgWz+PBQ12quXRtvIRyef67TPylwkJJHdy4AjeAg9+D/1UcIe/1V Wro6ak++2HXkqwoghVz5Nj8EUw/T296TMXxfiCfyz25oQYDQf36G2FD0Od2MVXSb4iKL+89 qqXN+7+WkSJ+gCxSF2W4R7MJYWx8PRPz6fP55YEBNdjnX2PgZKSshjJtZSDkupye4I9ASBT 10Ex5ojATVXD0nKUag= X-QQ-GoodBg: 2 From: zhaoxiao To: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch Cc: jordan@cosmicpenguin.net, saiprakash.ranjan@codeaurora.org, jonathan@marek.ca, airlied@redhat.com, smasetty@codeaurora.org, konrad.dybcio@somainline.org, akhilpo@codeaurora.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhaoxiao Subject: [PATCH v2] drm: msm: adreno_gpu.c: Add and use pr_fmt(fmt) Date: Thu, 26 Aug 2021 10:23:16 +0800 Message-Id: <20210826022316.9559-1-zhaoxiao@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybgforeign:qybgforeign7 X-QQ-Bgrelay: 1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use a more common logging style. Signed-off-by: zhaoxiao --- v2:Remove the line: #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt drivers/gpu/drm/msm/adreno/adreno_gpu.c:23:9: warning: 'pr_fmt' macro redefined [-Wmacro-redefined] #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt ^ include/linux/printk.h:348:9: note: previous definition is here #define pr_fmt(fmt) fmt drivers/gpu/drm/msm/adreno/adreno_gpu.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 9f5a30234b33..f10e9e04c13b 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -753,7 +753,7 @@ void adreno_dump_info(struct msm_gpu *gpu) struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu); int i; - printk("revision: %d (%d.%d.%d.%d)\n", + pr_info("revision: %d (%d.%d.%d.%d)\n", adreno_gpu->info->revn, adreno_gpu->rev.core, adreno_gpu->rev.major, adreno_gpu->rev.minor, adreno_gpu->rev.patchid); @@ -761,12 +761,12 @@ void adreno_dump_info(struct msm_gpu *gpu) for (i = 0; i < gpu->nr_rings; i++) { struct msm_ringbuffer *ring = gpu->rb[i]; - printk("rb %d: fence: %d/%d\n", i, + pr_info("rb %d: fence: %d/%d\n", i, ring->memptrs->fence, ring->seqno); - printk("rptr: %d\n", get_rptr(adreno_gpu, ring)); - printk("rb wptr: %d\n", get_wptr(ring)); + pr_info("rptr: %d\n", get_rptr(adreno_gpu, ring)); + pr_info("rb wptr: %d\n", get_wptr(ring)); } } @@ -780,7 +780,7 @@ void adreno_dump(struct msm_gpu *gpu) return; /* dump these out in a form that can be parsed by demsm: */ - printk("IO:region %s 00000000 00020000\n", gpu->name); + pr_info("IO:region %s 00000000 00020000\n", gpu->name); for (i = 0; adreno_gpu->registers[i] != ~0; i += 2) { uint32_t start = adreno_gpu->registers[i]; uint32_t end = adreno_gpu->registers[i+1]; @@ -788,7 +788,7 @@ void adreno_dump(struct msm_gpu *gpu) for (addr = start; addr <= end; addr++) { uint32_t val = gpu_read(gpu, addr); - printk("IO:R %08x %08x\n", addr<<2, val); + pr_info("IO:R %08x %08x\n", addr<<2, val); } } } -- 2.20.1