Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
In-Reply-To: <CAPDyKFp0O-N79QzHtoaC0+yWvYbTy1mGCjn7wivLvFvJ7_oNiA@mail.gmail.com>
References: <1626435974-14462-1-git-send-email-sbhanu@codeaurora.org>
 <d95ea0583c39b8e73f391502adb39b09@codeaurora.org> <CAPDyKFp0O-N79QzHtoaC0+yWvYbTy1mGCjn7wivLvFvJ7_oNiA@mail.gmail.com>
From:   Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.9.1
Date:   Thu, 26 Aug 2021 07:43:11 +0000
Message-ID: <CAE-0n53vxtDSh66+XxzMX38ccD6++E8v2ixYRonoihNG=ggqpQ@mail.gmail.com>
Subject: Re: [PATCH V4] mmc: sdhci-msm: Update the software timeout value for sdhc
To:     Shaik Sajida Bhanu <sbhanu@codeaurora.org>,
        Ulf Hansson <ulf.hansson@linaro.org>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        Asutosh Das <asutoshd@codeaurora.org>,
        Sahitya Tummala <stummala@codeaurora.org>,
        Veerabhadrarao Badiganti <vbadigan@codeaurora.org>,
        Ram Prakash Gupta <rampraka@codeaurora.org>,
        Sayali Lokhande <sayalil@codeaurora.org>,
        Sarthak Garg <sartgarg@codeaurora.org>,
        Rajendra Nayak <rnayak@codeaurora.org>, cang@codeaurora.org,
        Pradeep P V K <pragalla@codeaurora.org>,
        nitirawa@codeaurora.org, linux-mmc <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Quoting Ulf Hansson (2021-08-04 04:34:52)
> + Stephen
>
> On Mon, 2 Aug 2021 at 12:41, <sbhanu@codeaurora.org> wrote:
> >
> > Gentle Reminder
> >
> > Thanks,
> > Sajida
> >
> > On 2021-07-16 17:16, Shaik Sajida Bhanu wrote:
> > > Whenever SDHC run at clock rate 50MHZ or below, the hardware data
> > > timeout value will be 21.47secs, which is approx. 22secs and we have
> > > a current software timeout value as 10secs. We have to set software
> > > timeout value more than the hardware data timeout value to avioid
> > > seeing
> > > the below register dumps.
> > >
> > > [  332.953670] mmc2: Timeout waiting for hardware interrupt.
> > > [  332.959608] mmc2: sdhci: ============ SDHCI REGISTER DUMP
> > > ===========
> > > [  332.966450] mmc2: sdhci: Sys addr:  0x00000000 | Version:
> > > 0x00007202
> > > [  332.973256] mmc2: sdhci: Blk size:  0x00000200 | Blk cnt:
> > > 0x00000001
> > > [  332.980054] mmc2: sdhci: Argument:  0x00000000 | Trn mode:
> > > 0x00000027
> > > [  332.986864] mmc2: sdhci: Present:   0x01f801f6 | Host ctl:
> > > 0x0000001f
> > > [  332.993671] mmc2: sdhci: Power:     0x00000001 | Blk gap:
> > > 0x00000000
> > > [  333.000583] mmc2: sdhci: Wake-up:   0x00000000 | Clock:
> > > 0x00000007
> > > [  333.007386] mmc2: sdhci: Timeout:   0x0000000e | Int stat:
> > > 0x00000000
> > > [  333.014182] mmc2: sdhci: Int enab:  0x03ff100b | Sig enab:
> > > 0x03ff100b
> > > [  333.020976] mmc2: sdhci: ACmd stat: 0x00000000 | Slot int:
> > > 0x00000000
> > > [  333.027771] mmc2: sdhci: Caps:      0x322dc8b2 | Caps_1:
> > > 0x0000808f
> > > [  333.034561] mmc2: sdhci: Cmd:       0x0000183a | Max curr:
> > > 0x00000000
> > > [  333.041359] mmc2: sdhci: Resp[0]:   0x00000900 | Resp[1]:
> > > 0x00000000
> > > [  333.048157] mmc2: sdhci: Resp[2]:   0x00000000 | Resp[3]:
> > > 0x00000000
> > > [  333.054945] mmc2: sdhci: Host ctl2: 0x00000000
> > > [  333.059657] mmc2: sdhci: ADMA Err:  0x00000000 | ADMA Ptr:
> > > 0x0000000ffffff218
> > > [  333.067178] mmc2: sdhci_msm: ----------- VENDOR REGISTER DUMP
> > > -----------
> > > [  333.074343] mmc2: sdhci_msm: DLL sts: 0x00000000 | DLL cfg:
> > > 0x6000642c | DLL cfg2: 0x0020a000
> > > [  333.083417] mmc2: sdhci_msm: DLL cfg3: 0x00000000 | DLL usr ctl:
> > > 0x00000000 | DDR cfg: 0x80040873
> > > [  333.092850] mmc2: sdhci_msm: Vndr func: 0x00008a9c | Vndr func2 :
> > > 0xf88218a8 Vndr func3: 0x02626040
> > > [  333.102371] mmc2: sdhci:
> > > ============================================
> > >
> > > So, set software timeout value more than hardware timeout value.
> > >
> > > Signed-off-by: Shaik Sajida Bhanu <sbhanu@codeaurora.org>
> > > Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Applied for fixes and by adding a stable tag, thanks!
>

Thanks. Looks like none of the stable trees could apply it though :(