Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936740AbWLEW2h (ORCPT ); Tue, 5 Dec 2006 17:28:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S936673AbWLEW2h (ORCPT ); Tue, 5 Dec 2006 17:28:37 -0500 Received: from smtp.osdl.org ([65.172.181.25]:41719 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936740AbWLEW2g (ORCPT ); Tue, 5 Dec 2006 17:28:36 -0500 Date: Tue, 5 Dec 2006 14:28:31 -0800 From: Andrew Morton To: Josef Sipek Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] fsstack: Fix up ecryptfs's fsstack usage Message-Id: <20061205142831.9cb3e91c.akpm@osdl.org> In-Reply-To: <20061205192231.GD2240@filer.fsl.cs.sunysb.edu> References: <20061204204024.2401148d.akpm@osdl.org> <20061205191824.GB2240@filer.fsl.cs.sunysb.edu> <20061205192231.GD2240@filer.fsl.cs.sunysb.edu> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1350 Lines: 35 On Tue, 5 Dec 2006 14:22:32 -0500 Josef Sipek wrote: > Fix up a stray ecryptfs_copy_attr_all call and remove prototypes for > ecryptfs_copy_* as they no longer exist. > > Signed-off-by: Josef "Jeff" Sipek > --- > fs/ecryptfs/dentry.c | 2 +- > fs/ecryptfs/ecryptfs_kernel.h | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/ecryptfs/dentry.c b/fs/ecryptfs/dentry.c > index 52d1e36..b0352d8 100644 > --- a/fs/ecryptfs/dentry.c > +++ b/fs/ecryptfs/dentry.c > @@ -61,7 +61,7 @@ static int ecryptfs_d_revalidate(struct > struct inode *lower_inode = > ecryptfs_inode_to_lower(dentry->d_inode); > > - ecryptfs_copy_attr_all(dentry->d_inode, lower_inode); > + fsstack_copy_attr_all(dentry->d_inode, lower_inode, NULL); I fixed that two weeks ago. When your patches are queued in -mm please do test them there, and review others' changes to them, and raise patches against them. Raising patches against one's private tree and not testing the code which is planned to be merged can introduce errors. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/