Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 26 Aug 2021 10:04:49 +0200
From:   Daniel Wagner <dwagner@suse.de>
To:     Hannes Reinecke <hare@suse.de>
Cc:     linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
        Sagi Grimberg <sagi@grimberg.me>, yi.he@emc.com
Subject: Re: [PATCH v2] nvme-tcp: Do not reset transport on data digest errors
Message-ID: <20210826080449.6pzvgihxzqbsosrx@carbon.lan>
References: <20210825124259.28707-1-dwagner@suse.de>
 <42916ab0-2997-b19f-47ee-e20e8e868a86@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <42916ab0-2997-b19f-47ee-e20e8e868a86@suse.de>
Precedence: bulk

On Wed, Aug 25, 2021 at 05:27:10PM +0200, Hannes Reinecke wrote:
> > @@ -506,6 +514,7 @@ static int nvme_tcp_process_nvme_cqe(struct nvme_tcp_queue *queue,
> >   static int nvme_tcp_handle_c2h_data(struct nvme_tcp_queue *queue,
> >   		struct nvme_tcp_data_pdu *pdu)
> >   {
> > +	struct nvme_tcp_request *req;
> >   	struct request *rq;
> >   	rq = nvme_find_rq(nvme_tcp_tagset(queue), pdu->command_id);
> > @@ -534,6 +543,8 @@ static int nvme_tcp_handle_c2h_data(struct nvme_tcp_queue *queue,
> >   		return -EPROTO;
> >   	}
> > +	req = blk_mq_rq_to_pdu(rq);
> > +	req->status = NVME_SC_SUCCESS;
> >   	return 0;
> >   }
> 
> Can't you move the initialisation to nvme_tcp_setup_cmd_pdu()?
> That'll save to to have to reference the tcp request here ...

Yes, that's a why better place to initialize it. Let me spin a new
version.