Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp286359pxb; Thu, 26 Aug 2021 03:11:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvJ8ij/sH+NcbX7BlhcG47SznBN4nErzQ8yQAuIq9t+QjoyHBMTYA2FLi46lSTiR5ME0OQ X-Received: by 2002:a17:906:4784:: with SMTP id cw4mr3430734ejc.160.1629972692497; Thu, 26 Aug 2021 03:11:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629972692; cv=none; d=google.com; s=arc-20160816; b=LyeYQPvc3C2IMmvs+MeNh5gAD6Ne/BF8ajGZaEFg+bRlLkaIP6SOLHYoA3YRzRfB+2 GjT7/Dq5nfrqdjAuxqKopqAqW17YDla2Hrbd3/ULKRwWrEFzKDcbX/Gf33CHDF4+mS0M 2+dGxkv78LQIVQi0YJC024yOhJw9iHLE9h7gHxa1nyCct5cKLtFo3Up9b/m4Nq2qNj58 Jff3OClJXGrTnQWWdCuitMm8KGCUdfm16KNqn4WlU0qqoNAkf8+cK943QNhQM/54Oxql DN3+lU0A2sV4jlgK4oPk/UjvuTkBVwOZTVr6efn8ITX9svxmbx1sF7bJPyPxnz/uPVwC W5jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LpP6DDOvqx7/hUMNrvyusUHSsFQjDuznakHe/WkI5qA=; b=MgjpNhE2KZkIKWdHOuedlOnHtBC0CuUURs3yk/XogDd5jibtHCWvanY2oNa6cdWPO0 KUCvlXbyohKQyayARAetezbBR9nPfZlgISkvcGkMUxY4VZ4ecK7T5MqgSQtUq3bjOZeA 3MF0iE3fjZzBTFdDqqRMaGgglWYSqCm5dNUE4aWUSyZ9H6s0yIxGRnIXyUVtU/tv0Rcv zdBUKzy1e9+gcA8wxSeSu7cOVEvO63x575SqVwolMgfbA9PzwDOGVD5NDcwlXvWZCCTM BrgHTZz+F08pFruj0bXyTm7vsftj7MwLtNiGL2sfj2h7yOF/VgjbwnGLOQoen+2N0+Vo 9pTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aQVsZ9JA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c2si2361312edt.157.2021.08.26.03.10.54; Thu, 26 Aug 2021 03:11:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aQVsZ9JA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241202AbhHZKFi (ORCPT + 99 others); Thu, 26 Aug 2021 06:05:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:41384 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233880AbhHZKFh (ORCPT ); Thu, 26 Aug 2021 06:05:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 621F9610E6; Thu, 26 Aug 2021 10:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1629972290; bh=uqKb6h0Wiejse2anuZ4qCYAvlJ79825SKg+gZQGrYog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aQVsZ9JAF3ZrBhI0vq+RuHkxjmM7SrqHupJKh/w5ZsIseHYkATITGV+m1/lJQ6NgW fw+oiW41cYa6pDNP0iU6/MP1CXzDrfginSU2OH6/7rv3Y9yOVJhedvJu/pVpN/qmRa FKTfcNViwfRSWTHkSgWiyKCjPwWLwYtc2Hcgn4LI= Date: Thu, 26 Aug 2021 12:04:45 +0200 From: Greg Kroah-Hartman To: Bryan Brattlof Cc: "Fabio M. De Francesco" , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] staging: rtl8723bs: remove unused functions Message-ID: References: <20210822204212.2832397-1-hello@bryanbrattlof.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210822204212.2832397-1-hello@bryanbrattlof.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 22, 2021 at 08:42:58PM +0000, Bryan Brattlof wrote: > Changes in v2: > - Remove build warnings I introduced in the previous version. > > *** > > There is a lot of un-used code and un-needed abstractions leftover > in this driver from when (I assume) it could be compiled on more than > one kernel. > > This series removes dead code and is one small step toward > refactoring how this driver interacts with the SDIO subsystem. > Better, but these are still not threaded properly (some were, patches 1 and 2, but not the rest.) Please fix up and resend a v3. thanks, greg k-h