Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp305076pxb; Thu, 26 Aug 2021 03:41:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTdYZrstcB6wjgonailMONs+lIvdO6JqIjCp3VeHdPvCeX6MzO34YtSD2XILqwhWD0HBOW X-Received: by 2002:a17:906:af4f:: with SMTP id ly15mr3577590ejb.175.1629974498880; Thu, 26 Aug 2021 03:41:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629974498; cv=none; d=google.com; s=arc-20160816; b=AuNOj2YJfsjlByG1z9VuJXbe3TPKVa+ac1LFFD70xlead8J0sitKeEw5cCVwgyHNTf us4L/QfsGyXjcQiXDzw+OsLg1QSzvoNaon+pFr5bngFIm3Hi8/G3mX79MwckaGhuE5jJ FmivMwtaKzil8K4mcwzuHdtM891lIsvd4Gl0OmNfRPJdV9M2iYgncPoRqgoVaZ/x8ezY r3vRU5REOb9YCFZCQIwpzacc9u+sHCYEM2H/eHCFyr+t+Uue0Vhs89BquW1zWXs5F+k2 Q0WXWL2vl0cgjHrcBje7Az9oyd8tw6+6cD6GTlkLS5ue8jmaTPOh0zQNSke8+cuaC2VA veUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WKRAqzcELmK+orl47vNgZkW79aImHKp6d+GNPvAWynw=; b=eHND5QDxK3uKBfMQ/Aj/NIrZfKbQjpsNozsFMVspy2j4Bg8g3yTGPUCy4aeAauK7H5 usOJPRBM/vZDqD9E28M5ztUD7gZTdh3/sZzhyDoHaO6VqdY34jQmeF0C+EJq4vwuPGsb 1YCe+NPVx/DPbOLZsAqkojiYnPrz/zr6Zd+1GWkDOXAOit+zm35bNcVmGdJHB/oA5jub xEquNQ/OqvOdWNFLJvVJmFfh7a/h42b7QxXuykzJ4LbELa5ni4IPukCZGdaq6+e3jT11 wVLSlPnZ4oKFkLJ2dSC5AnsitqFoUEcpzIzE/z91h52tuk7aqmqPc6rVaoohGegmr/Mr HLyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DzAxaPWo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j11si2781866edw.382.2021.08.26.03.41.12; Thu, 26 Aug 2021 03:41:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DzAxaPWo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241459AbhHZKkP (ORCPT + 99 others); Thu, 26 Aug 2021 06:40:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:49260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233929AbhHZKkP (ORCPT ); Thu, 26 Aug 2021 06:40:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6C8576108E; Thu, 26 Aug 2021 10:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1629974368; bh=Kb2BRqJnhgCEFtwwhEQxATLUmyDZuDxe9+QdYedO9iM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DzAxaPWoy2aAMRtvCvBRb/MtNk0GOEfGvNTAb+0dDMr59Aa6AvhC+P2RetXyksCsH VR64JQaY2QUT2r3iw3dZvifvkB1KOAOsIm41qyEKBI17QuwkyOqcvH7EsWO+0SJXAG X2Uec6IjXwEhBTHYBUSGXYFHi23sHVjxutjgFBsI= Date: Thu, 26 Aug 2021 12:39:23 +0200 From: Greg KH To: Pavel Skripkin Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] staging: r8188eu: remove {read,write}_macreg Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 24, 2021 at 10:27:13AM +0300, Pavel Skripkin wrote: > These 2 functions are unused, so they can be simply removed > > Signed-off-by: Pavel Skripkin > --- > drivers/staging/r8188eu/core/rtw_mp.c | 39 ------------------------ > drivers/staging/r8188eu/include/rtw_mp.h | 2 -- > 2 files changed, 41 deletions(-) write_macreg_hdl and the read version can also be removed, right? thanks, greg k-h