Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 26 Aug 2021 14:08:07 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Nick Desaulniers <ndesaulniers@google.com>
Cc:     Pavel Skripkin <paskripkin@gmail.com>,
        kernel test robot <lkp@intel.com>, Larry.Finger@lwfinger.net,
        phil@philpotter.co.uk, gregkh@linuxfoundation.org,
        straube.linux@gmail.com, fmdefrancesco@gmail.com,
        clang-built-linux@googlegroups.com, kbuild-all@lists.01.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/6] staging: r8188eu: add error handling of rtw_read8
Message-ID: <20210826110807.GY1931@kadam>
References: <c59d5d850bf9aab208704182c83086609289cb9c.1629789580.git.paskripkin@gmail.com>
 <202108251911.Vwmzl4rI-lkp@intel.com>
 <9743e1ee-75f4-6231-427b-8c7f659fb252@gmail.com>
 <20210825125159.GU1931@kadam>
 <bd50c00e-1814-dc32-36cf-73cf58123201@gmail.com>
 <20210825133432.GW1931@kadam>
 <c982eea8-3b16-656b-dcb3-1b6e0d3e995d@gmail.com>
 <CAKwvOdn61==-pLs6oDUjeCD7DQvWjRx+b+04JMpN8w9kY9P-uQ@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKwvOdn61==-pLs6oDUjeCD7DQvWjRx+b+04JMpN8w9kY9P-uQ@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (62.8.83.99) by JNAP275CA0058.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Thu, 26 Aug 2021 11:08:20 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7777c731-3361-4f8b-0be3-08d96881d40d
X-MS-TrafficTypeDiagnostic: CO1PR10MB4643:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB4643B552C101422580EB91E48EC79@CO1PR10MB4643.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:195;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: W35jYRwGUH+SFq22B1Fc8h8x3yYw1I62lKbCKgZVJEV75/StDuL4Rsdh8F2PfFDIsaeTpmsSXwlsJlvWZGJkkk09+/oaExKha0MsIHCagTL2J4FFWga5wyFBIGVwJSKm4lgl4s8KLCyyWBKlfQPIlsVB+yBQYe1o6zF0VDJTkc+0yAVegY2R1eTqKRucpm6EnQ8yMw+kc1LLIFtUnCRGNOZVQEdkgZiAvajQhmxY0NZAhh0kQKt3KfPETi34FTQ5seonYywLGYqqy/qasUVVC3b87FBwtt5aAznweULNnpO5f1tYn3PjSd0Sp6sJXL6kuyYfV/4j1ukmW3hDn5+a+2juWd70rxI7ltzlxQaq/MNol/vmqDfaxNF3JdygZezascGxWFilVwmieo9shvclQCWIcqgoS+VPmT+DGzSilD6ri0S94u4ytcJOLW7tHfJZbd/L97fW56uUjMdR2gvMJ7tfgVoGKsJK3xz4yMNFycNm+/bLu01RDOb4Q3k+XUzMVYx+EwpikpNGEb6fNgQR8fx919NaN04syfaLqHP5J5Von7gK0VNn7AKgDrivTkk1BiCaL4vgWP/deEMeKBitsH58BLpKyunJHrj2qxY7T4VAGDJZPsC4y02c3/t/WptxZQreaLbvgp5YP6l/T47/LEglKc9pEniOOTSN3DFzDtqZntmIQPoiLUARCkSSvd6IxB4PMKFTxt/CpFFhCNLRYQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(396003)(136003)(366004)(346002)(39860400002)(33716001)(66556008)(5660300002)(66476007)(53546011)(66946007)(316002)(9686003)(6666004)(1076003)(6916009)(4326008)(9576002)(6496006)(2906002)(38350700002)(956004)(33656002)(8936002)(478600001)(83380400001)(186003)(55016002)(86362001)(52116002)(38100700002)(26005)(7416002)(54906003)(8676002)(44832011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jdP+NuLNyvlGidUFH7ItW3ozO2ooEiI619YHceNLjh0+jY/g+irNtuiEd1pE?=
 =?us-ascii?Q?RdibIusnXIomxfSBXajofpJmRPHqEbvtClGMoSzz5nYHeuCkAWRFjttn4nmV?=
 =?us-ascii?Q?iSy/lqgFvFd4dQcX58RuFSNqR4Gl9USsu3OmodeELuFgKcK36eZeFKHymLkW?=
 =?us-ascii?Q?Vp/yy5R68Kqc7xKQLER+2CFmPylCcPsg7kWIKdOMl9iExbFWl6T6QOmGh96b?=
 =?us-ascii?Q?i9/gjHgYWqTgNUiEyfuV8ZrWvHlNMN/MIcPkXobFX3r8sXUfJPsiG5LyV1MY?=
 =?us-ascii?Q?K/CYaJFVtg+wk7Q0u+LYAxFd4w+FE9SCd9Umr1rhx+a4/300vBLEsCU/5X1J?=
 =?us-ascii?Q?Klx6ZxgVyZoKVGfHK3wkecpewcOkbaVJhTM+0hrUX4nY9NvRs9vT/e/RqXEd?=
 =?us-ascii?Q?+7xR271HisZeyJ7xYNW/ykZ9K8TujS7MsLuhl7z0wVsixvf77YFGc075xbrr?=
 =?us-ascii?Q?TSwTmCfcxP9sVzNbT+Kr6e/90IkXgYgQrwuiSnZdVibE+EdyNY5fEmO5ewDu?=
 =?us-ascii?Q?Excqd7JLhWgzOwd2a00TL/3dUyXKeuyxU1SBcxAGA7zHi38eTNYK5bkM5v/h?=
 =?us-ascii?Q?kXotwOF3Bnl3FplVAhRIoWYTt4UkvV/D64w+P8tVte75Rej3saw0TxQm+2rz?=
 =?us-ascii?Q?JC+QECjVoMHs1tw6YDQB3JhnaEiNXjZNGTLPPnBS9ziuC+iGrbzDFbfQG25z?=
 =?us-ascii?Q?W9ndBXzpzae0GpOb+rKRuSjDns9NN1hmZ+kbD5sghebDoJdmV4oAtYIJnXRO?=
 =?us-ascii?Q?0rNa6BFqESkk6xzlK4KrVgWYUPkdfVbO09oS0kqHoyMX5X7l/ygXjb1AWSJb?=
 =?us-ascii?Q?TpW3relVrme/Y0Y6FQ6kdaAiWKfjig95MHC+osFCNLVMydSyq0JduUa9PxR4?=
 =?us-ascii?Q?odzNhZjKEdA3jDHVrfjZwZ7anTh/Hnr7RsfP8xqXA7OmjvWWIwqDZb++F4Mw?=
 =?us-ascii?Q?7NAfJrnhAKjsbvC6CyC/QHQ9CMROI9l77kiB4r4B/mZGrt7aoGFbVQ5G6P6T?=
 =?us-ascii?Q?gD4RcZa2vhAP8eDAx2jR2ee0zPiSe0WVPd2vTenf1JYUWIqTwpQHIz4bIxxB?=
 =?us-ascii?Q?sXbE3PorCTfiqa29w5MiPHDL2nhEi72IxDcVRhy8YrumMq0rld3+3y7r1Qk+?=
 =?us-ascii?Q?Y/NsglCYiuObGbpykHDxPCSVhSgIYLejjo6OW5T0eblIMzidJqwP5HPFYzKY?=
 =?us-ascii?Q?wGRPhWXJ/XTj6ZpZ9JzoIr7GAmqi5AijMe42d//LsOpuByu7zxBFL3S5HKi5?=
 =?us-ascii?Q?DPiUWv0+/N48MAgA5mHoeIYCIBGoWoGuvJEqFCNPeiJjCTotgZWp7hdtOcYN?=
 =?us-ascii?Q?MZBd55SLHGS5qUu3HJKAsUgQ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7777c731-3361-4f8b-0be3-08d96881d40d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2021 11:08:26.9566
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TE9kj22euQYbpK0BW5GD+l4KKQGumc6qltdlNJe0KYpAwmZtjtk6E/5GmFti2sAfoCy9+7H10V2DYAr8FV7Mc7HkGR/ofHoyfswuTX0XxpE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4643
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10087 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 adultscore=0 malwarescore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2108260068
X-Proofpoint-GUID: Vsc8Dh6Dtr5p8qaoWFNJqCbNYlbnPVqS
X-Proofpoint-ORIG-GUID: Vsc8Dh6Dtr5p8qaoWFNJqCbNYlbnPVqS
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 25, 2021 at 10:11:45AM -0700, Nick Desaulniers wrote:
> On Wed, Aug 25, 2021 at 6:44 AM Pavel Skripkin <paskripkin@gmail.com> wrote:
> >
> > On 8/25/21 4:34 PM, Dan Carpenter wrote:
> > > On Wed, Aug 25, 2021 at 04:02:26PM +0300, Pavel Skripkin wrote:
> > >> > This is not related to your patch.  Ignore it.
> > >> >
> > >> >
> > >> > > > vim +2022 drivers/staging/r8188eu/hal/usb_halinit.c
> > >> > > >
> > >> > >
> > >> > > >    2020                case HW_VAR_BCN_VALID:
> > >> > > >    2021                        /* BCN_VALID, BIT(16) of REG_TDECTRL = BIT(0) of REG_TDECTRL+2, write 1 to clear, Clear by sw */
> > >> > > > > 2022                         u8 tmp;
> > >> > >
> > >> > > Hm, I don't know anything about ARM compilers, so should I wrap this code
> > >> > > block with {}?
> > >> >
> > >> > Yep.
> > >> >
> > >> > >
> > >> > > My local gcc 11.1.1 (x86_64) does not produce any warnings/errors
> > >> > >
> > >> >
> > >> > You should figure out whats up with that because it shouldn't compile
> > >> > with the gcc options that the kernel uses.
> > >> >
> > >>
> > >> AFAIK, at least 2 guys except me in this CC list compiled my series without
> > >> errors/warnings. Maybe, staging tree is missing some Makefile updates?
> > >>
> > >>
> > >> I'll resend series this evening anyway, but this is strange....
> > >
> > > Hm...  In my version of GCC the error is:
> > >
> > > drivers/staging/r8188eu/hal/usb_halinit.c:1870:3: error: a label can only be part of a statement and a declaration is not a statement
> > >
> > > That's a different error from what I was expecting.  It's caused by
> > > having a declaration directly after a case statement.  The warning that
> > > I was expecting was from -Wdeclaration-after-statement and it looks
> > > like this:
> > >
> > > warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
> > >
> > > You really should try investigate why this compiles for you because
> > > something is going wrong.  It should not build without a warning.
> > >
> >
> > Looks like it's bug in gcc 11.1.1. I've rebuilt this module with gcc 10
> > (gcc-10 (SUSE Linux) 10.3.1 20210707 [revision
> > 048117e16c77f82598fca9af585500572d46ad73]) and build fails with error
> > described above
> >
> >
> > My default gcc is
> >
> > gcc (SUSE Linux) 11.1.1 20210721 [revision
> > 076930b9690ac3564638636f6b13bbb6bc608aea]
> >
> >
> > Any idea? :)
> 
> The original report said the build was with clang-14, which is near
> top of tree and unreleased. It's possible that that build had a bug
> that hopefully was reverted.

No, Clang is right to refuse to build the code.  It's GCC 11.1.1 which
is wrong because it allows it.  I'm not C language expert but we're
using the -Wdeclaration-after-statement because we don't want this.

regards,
dan carpenter