Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp352126pxb; Thu, 26 Aug 2021 04:51:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwGgliix5XUZ4QO7Yg3kczTz0gI0ct8lqIQxj5jtc/xnz5sSpu0wmB3HR+OzQjBf2nsnvY X-Received: by 2002:a05:6638:81:: with SMTP id v1mr3160699jao.11.1629978713348; Thu, 26 Aug 2021 04:51:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629978713; cv=none; d=google.com; s=arc-20160816; b=VXyKkGk/w4tbyHFixm6fhD3NcLJW32k2Ja2cW+3lZ0vGs/eQElFavcsSk+gwSnTvHa CSQRINIMAPR/sO0oHYHP7KU+Hb9OUykqIS2GDN5SZrZp46U2GCjuW6a2U5mU39PmwgXb hPLzBDPHxeYZbOx1u7iyyqQc7yALbVPXjk7onpRRsejZk3699JFQMNUpQk9lM8Vt0aPG 0v+Y3fHIljp01ymMXMWzAM+0tBVZOLjdJcjfHDQInhPBMgFqi+frZp6J5O4gs9g8nNeo IBc10OKs0hmesY3GEgT5eFAqyo4VBSfoa+W+Nz3zYjg8i8WyVts1pfPqucbC5I9qtSNP EXXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=YNjHjIK/En27M3UOTxYlnHIZO0PEu2UjfyEkvc9ojPw=; b=sQJlGg2s9I5TFfc1f4jKNP4Q2DH6ss+MJgCZHg9N568vMIfsbneTscLXTr+GzuvZDC 6KDxFu2U9oZF/huHo+7+vgMJwJUOZG/aINylskycacZJUw6lYDrDJXZLdaYLGr8jnQw1 p6IZWzmxGfEEwKxeHotDIN1FmcqPExD74TPP2+XjKHNwwc7LIpqu3hd2pbFK09TB7Igf 2UxUpsnWgT8ZuScNfDDZhGirWbF3sQIone5tHDEbumoplDZZwlUoEDv0g/j3vlnbZIoa 0L3D+1xjWLzQ4RHVSv7n3noaqkQxOPu0AQUgt885+Dp/DCNX9SvwW5Ogo6cF0NtdmH3M EJpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h11si2721755ild.67.2021.08.26.04.51.41; Thu, 26 Aug 2021 04:51:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242327AbhHZLvJ (ORCPT + 99 others); Thu, 26 Aug 2021 07:51:09 -0400 Received: from mga07.intel.com ([134.134.136.100]:45624 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242100AbhHZLvI (ORCPT ); Thu, 26 Aug 2021 07:51:08 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10087"; a="281443945" X-IronPort-AV: E=Sophos;i="5.84,353,1620716400"; d="scan'208";a="281443945" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2021 04:50:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,353,1620716400"; d="scan'208";a="465099620" Received: from linux.intel.com ([10.54.29.200]) by orsmga007.jf.intel.com with ESMTP; 26 Aug 2021 04:50:21 -0700 Received: from linux.intel.com (vwong3-iLBPG3.png.intel.com [10.88.229.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 719855805A3; Thu, 26 Aug 2021 04:50:17 -0700 (PDT) Date: Thu, 26 Aug 2021 19:50:14 +0800 From: Wong Vee Khee To: Andrew Lunn Cc: Florian Fainelli , Vivien Didelot , "David S . Miller" , Jakub Kicinski , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Heiner Kallweit , Russell King , Voon Weifeng , Michael Sit Wei Hong , Vladimir Oltean , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: pcs: xpcs: enable skip xPCS soft reset Message-ID: <20210826115014.GA5112@linux.intel.com> References: <20210809102229.933748-1-vee.khee.wong@linux.intel.com> <20210809102229.933748-2-vee.khee.wong@linux.intel.com> <20210810235529.GB30818@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 11, 2021 at 04:20:56PM +0200, Andrew Lunn wrote: > > > BIOS does configured the SerDes. The problem here is that all the > > > configurations done by BIOS are being reset at xpcs_create(). > > > > > > We would want user of the pcs-xpcs module (stmmac, sja1105) to have > > > control whether or not we need to perform to the soft reset in the > > > xpcs_create() call. > > > > I understood Andrew's response as suggesting to introduce the ability for > > xpcs_create() to make a BIOS call which would configure the SerDes after > > xpcs_soft_reset(). > > Yes. Exactly. That is what ACPI is for, so we should use it for this. > > Andrew Thanks Florian for the explaination. I have checked with the BIOS developers and they did not implmenet a method to this at the kernel level. Also, Intel AlderLake has both UEFI BIOS and Slim Bootloader which make it least feasible to go for the ACPI method as per suggested. Regards, VK