Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp353301pxb; Thu, 26 Aug 2021 04:53:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsrIJunRL9kefIShRt/t4G5tRPv3yETxzaAXq0cVutIteYfFW4VFuCuvDCmInG8nJv/0zY X-Received: by 2002:a05:6e02:130e:: with SMTP id g14mr2439421ilr.81.1629978838671; Thu, 26 Aug 2021 04:53:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629978838; cv=none; d=google.com; s=arc-20160816; b=ookEuoKQQySrvLqSji5ff6wwcrfZRAChigIRSbp54GWjBtTzR7yenehPS3soSdVQta EFJlXauDURv3aNqOujqtKMpu+wAeNyu7c313CnQYXdiqMivpL4TGLhKBWVKUjwFAG8b7 1nZtz8qZEswrBSkCCpCtxlSR+Dgu6B4YdL7/5aFX1jtYsbtSMN+Ao9CIyLOx/SIJn3yr QWRpJpZMcJAExmu8gOGXx2NE35EdRxSEcLShLmSxhyl3kX33QsuSP+j5J5IpKeevCqyr gy3VfK6BrJnpxSkvPjlNq5tIQXIV4LiE5imaEVJ+NpF/p/kVnoYP/Z00h57snBj7mJGq KUcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=hBxBPr3Kmhx+gtlKVfwmBEiG03qJgZIhVmQgwh7w3cs=; b=Gk6z2zkCv/eSe77uR4LSS0aWJZ4j0PiKg2Nxi+51EBLpRaE5KA6pn4uZyUBa3sDU/A ZwGtSmAvmY+DEVGTGgaGQkMiF/jpySRp0sfk0hHJa36hk/RAxqzEEE4eIX6GNWVj0DW0 AKHrc84D159zpE284X7LecGQuiJCf9gkSO/k4RMvFkpETr2WLlvlJFHOkvEwsNZTKnuT 4lBy4Il8ZwD4IYOa2jGiq2/1Z9Ht4tI1jGYBbqA5GFN8pk81W2jpk2/TG7ZgQqhlgUzY fY1QJjUXCWrhfSJMMOEp1wsUs1j+9ift3EKbaLo9Ol31lP/cC4ifPJR3HvuAfXzgvE0l K9sQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FB0fHEaV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c18si2381951ioz.59.2021.08.26.04.53.46; Thu, 26 Aug 2021 04:53:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FB0fHEaV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242147AbhHZLxx (ORCPT + 99 others); Thu, 26 Aug 2021 07:53:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233829AbhHZLxx (ORCPT ); Thu, 26 Aug 2021 07:53:53 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0635C061757 for ; Thu, 26 Aug 2021 04:53:05 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id f2so4640575ljn.1 for ; Thu, 26 Aug 2021 04:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hBxBPr3Kmhx+gtlKVfwmBEiG03qJgZIhVmQgwh7w3cs=; b=FB0fHEaVXvKluHgvDlnT+jczLkZlGErjJJcgRmo6eZQTf8xdHEvDAuWFcB/QkxF4am 7sLfKCqAoC/rjaaZHeVT2p9sjEtnFNvrhixpDYcebthv5V3m1B5T6dFAzyInBteoOSNd y9P1RkLqYOd5FxhAiqyQxxXLQBsMJMWpioS0KfxUkaik13asCvQy42uEp/vg36WtcETW oHKYlfRq4qtHu5Lycp66zFgKzPZ7iorXB4UMbRosPksChFZByPmFLl8EsXkWmWG6hv6h LImOeUz3lp8A2xT7OPoa+JpAxsfvM8+5SVf5hb3uUjEoDbQoU/rBuk342Bvys2IgoDKu uZeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hBxBPr3Kmhx+gtlKVfwmBEiG03qJgZIhVmQgwh7w3cs=; b=jkxidXz8RXklZiBun5YsEclclv95G2AM8/XU81seekHle4yFzRMKl4jBo0Nn9Bkigs 22ir6Fdu5FtPai6AsDvFbSru8CdFAtilYs+9TMy9ck0+1cONTPg76XVmFOLs+B1iNhBO RDrV5WqG8qPcbY0vvUcHRQjCreuzGCEvCQtDxHmBW5vKKsC2MfxD02UYY9sltRUVBAk9 /I5EIRKAzUFEk5aL1y9GwgeEMN0UbSXcVSTFgiYaj5haTp/FqC/h14bS3qGumLG/HTP7 x90o2JIlRGyE6nvAnG2z737yrCcyf+eB7dpQVg+3HX9IEyyVNJ6NbToJVIE+kEaDkx6e Wviw== X-Gm-Message-State: AOAM5306S8i3UBtfb0MABYWAbbHlfwOuwSPRlWI9rhz2bpmBIn/S6eQy k17udvqB1PH9seVHBEb2sH3GIGsBMnY98jSALvM= X-Received: by 2002:a2e:a903:: with SMTP id j3mr2694040ljq.347.1629978784221; Thu, 26 Aug 2021 04:53:04 -0700 (PDT) MIME-Version: 1.0 References: <1629975460-17990-1-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: <1629975460-17990-1-git-send-email-shengjiu.wang@nxp.com> From: Fabio Estevam Date: Thu, 26 Aug 2021 08:52:53 -0300 Message-ID: Subject: Re: [PATCH 1/2] ASoC: fsl_rpmsg: add soc specific data structure To: Shengjiu Wang Cc: Timur Tabi , Nicolin Chen , Xiubo Li , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linux-ALSA , linuxppc-dev , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shengjiu, On Thu, Aug 26, 2021 at 8:19 AM Shengjiu Wang wrote: > + rpmsg->soc_data = of_device_get_match_data(&pdev->dev); > + if (rpmsg->soc_data) { This check is not necessary, because rpmsg->soc_data is always non-NULL. Other than that: Reviewed-by: Fabio Estevam