Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp371069pxb; Thu, 26 Aug 2021 05:18:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzelw1zQQpq2VmUS1L0VCxrOarb4Ry/NlgK2anKBsx/USrfPVnuHJ+9zyJsn4EiFQjACHb5 X-Received: by 2002:a5d:6e0c:: with SMTP id h12mr3688988wrz.334.1629980290319; Thu, 26 Aug 2021 05:18:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629980290; cv=none; d=google.com; s=arc-20160816; b=lheMBJv1F+sroLiLNwTphGmY2Z2hgqVN4Hh2wPQVYj8Xz7y4GyBoYELVLbFTeYDiNa O03OtlGkBvAf8PI1bco3I7S0zYdP3QQDp7Eo/6yihUlFsLQElZgf0e7n92C8x9Wg1aPb EUiOvmq0elFzlvRQ8PBXHu6nTyvhuB7tPgoggRMBiIemW5u6S0MAwOHVH7Y9OvWJJXzh 51ycE5bRK59rDRsO7VEnmjEXRyOH63oO1wnPKrZAcGuBZwxuPLKuqxLzTE03+rQsHugP Qvpksralpn6xhiI0KwgVGkRYn3Fecvm62aCL3ZiQiUFMEfg7XgCdPC1QcQ7vcc9fRTNF IqNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TRtL4257U7HQ9HSWhs33zhviZUifqBtCKs/0jahRZT4=; b=DzZbxy+AQaKKF2hYstmPCqMUEs3TjH7eBvfO2y6x3eynwuXSLqEmi0exartqNT6xJH fdjakKn+sKuo62SBTp6gz4vifVq4nQB4VM6KWptwh1mO1lwIMoLxXQebGUL9CvHSJaU1 KybGhk+AaJPCiQKVWGBi0LslTI/6MegKjMqK5eNqSOoPY43pHUFK5+qqKZCyQvIokw51 XQxZygcDtw7wS/tUgCLsc7CVt1NokReXROsI5tJ4qaAJlORNg3juyI6LmCxDUFTFx2JL X6gRqTXI3iFeCbsSKHCKo+sTiHK9Ca0WufVaTBiUuiCNWwTqhfwqDCarRdBpZqQ//HlX P6Mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=R6rbC20z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cr15si3773091ejc.254.2021.08.26.05.17.23; Thu, 26 Aug 2021 05:18:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=R6rbC20z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234453AbhHZMPY (ORCPT + 99 others); Thu, 26 Aug 2021 08:15:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234295AbhHZMPX (ORCPT ); Thu, 26 Aug 2021 08:15:23 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2195BC061757 for ; Thu, 26 Aug 2021 05:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=TRtL4257U7HQ9HSWhs33zhviZUifqBtCKs/0jahRZT4=; b=R6rbC20zVAKo6S7NFA+v+Itej uq6GQvVFmRkDKERnaO2juLauqL29bxaIVuHQmWkY09CEdNIw7jTghF1hJkES5ID7cal4+VjrYgwBb l565CvpUOlOgliXUqSYMyjlS6RvSiPyudsWRmrLdB+OrPxbJwDwn0EvKV8EpGlx37wGLv4LNLZ6g0 3ugDKSQnne6BdP53UyN9G1bxPtnECzGFjoShV9mJrEy/FiAPCbjS0D0+pa4GI2lEFld2xqAYcZhLu R0vGStupwg1DBpQJv7Fv8RcEFOYnGBaINDlV+4gZwGhiesj+GMOij7j55XhHqChiGds66EFQuLLKi rOHlU/dhw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:47710) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJEH6-0007s6-TK; Thu, 26 Aug 2021 13:14:28 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1mJEH4-0000o5-Lj; Thu, 26 Aug 2021 13:14:26 +0100 Date: Thu, 26 Aug 2021 13:14:26 +0100 From: "Russell King (Oracle)" To: Michael Walle Cc: etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Lukas F . Hartmann" , Marek Vasut , Lucas Stach , Christian Gmeiner , David Airlie , Daniel Vetter Subject: Re: [PATCH 2/3] drm/etnaviv: fix dma configuration of the virtual device Message-ID: <20210826121426.GR22278@shell.armlinux.org.uk> References: <20210826121006.685257-1-michael@walle.cc> <20210826121006.685257-3-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210826121006.685257-3-michael@walle.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 26, 2021 at 02:10:05PM +0200, Michael Walle wrote: > + pdev->dev.coherent_dma_mask = DMA_BIT_MASK(40); > + pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask; Please use dma_coerce_mask_and_coherent() here instead. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!