Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp372349pxb;
        Thu, 26 Aug 2021 05:20:02 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxrW4t0Aa2+HnYJVPvp2Bl/nWst7vIX6pv3AjqE/qAFeHObelQwShaoDFfX7OyoHy+NoZ09
X-Received: by 2002:a92:440c:: with SMTP id r12mr2480138ila.174.1629980402311;
        Thu, 26 Aug 2021 05:20:02 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1629980402; cv=none;
        d=google.com; s=arc-20160816;
        b=nBWGdFyvX/+8nr9eM6lK9TMJEFhocIidy8jUUQJMGQ/Bj6DPAuKgpoaAW2beevso5O
         8DcCQt3x02Sdc3doJ6wWIjunSTHW6lZYKEq/6uk8PgFKqyf8OlnpAaP2Woday8H5I9S+
         R0FDOFRcCEzEECpMm6anc/fFrdxQFwUXjUwSXOkqy+dIdnc8z1diX7+SezyKbbTtUfkW
         QX526E2jnLl8vXTC5eUgnyo1Jb8qJFNbeZQv5UJL3O6mRriXHb6U7wPE2RRgwUf0hnr2
         s+z+nD3ENSL2OStMX52fYp+RYLBWW8MeBRGFUcSD+UYR1tM8XjkcQ6HpVvFqBhqT6ux8
         4bNQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:message-id:user-agent:references:in-reply-to
         :subject:cc:to:from:date:content-transfer-encoding:mime-version
         :dkim-signature;
        bh=ph0v+Bk7Np1hcCXD7mWsaKWmwgPPFWEPG+SQv38Uy3I=;
        b=fMKm4+LSwS95l0AVHxFC71xiLSyGXlC6ByCVYGsSJcsyymjVCWocA1utQbMLf3KE1g
         cKKhZIInvbRLITxzU0g6mFHQyX4+Z3RLRpFjvwFbTF4ZjjaicKiavYuxt+xN3UfS/1T2
         LeKSXXuWExqKTBhNdAfH/Lse15BSnV2KdLAwx0ruKlZDIlhcgliSBy/8EIgOYA1Ez3ah
         SdRBasNqqakKgOHPK+hZAc1SibQhEXgW5NXeOWHPFoUgI8sboE8atrkNPpOX6rys5rod
         8eM3Dx86S7s4VMv+ZKOLB1GAAT2Iwh5SUxogsCA2WrJ+2MZmdq1fX1ZoEOebEfMNZ8/h
         LZ5Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b="Fv1/NAqT";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id u3si2869726jad.73.2021.08.26.05.19.49;
        Thu, 26 Aug 2021 05:20:02 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b="Fv1/NAqT";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S242415AbhHZMSY (ORCPT <rfc822;liukuiyu0707@gmail.com>
        + 99 others); Thu, 26 Aug 2021 08:18:24 -0400
Received: from ssl.serverraum.org ([176.9.125.105]:42187 "EHLO
        ssl.serverraum.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S242404AbhHZMSY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Aug 2021 08:18:24 -0400
Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ssl.serverraum.org (Postfix) with ESMTPSA id 18D5722256;
        Thu, 26 Aug 2021 14:17:36 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301;
        t=1629980256;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=ph0v+Bk7Np1hcCXD7mWsaKWmwgPPFWEPG+SQv38Uy3I=;
        b=Fv1/NAqTNUuuth3zPm7X0Ir//6tzhF2bNK0eh/vTzdpTdujEGy5Z6qLODK0i7xLIFkH0PV
        m5BumCufw0obsOXFckyj2q3t4m5CZDJaEnMpo06+5XXZzPyrDVEoJvbFmCrtXIqNAq+dx6
        +c9U4whUhq33k2WwLUN5z3h6UTALRBc=
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 26 Aug 2021 14:17:35 +0200
From:   Michael Walle <michael@walle.cc>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org,
        "Lukas F . Hartmann" <lukas@mntre.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Christian Gmeiner <christian.gmeiner@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/3] drm/etnaviv: fix dma configuration of the virtual
 device
In-Reply-To: <20210826121426.GR22278@shell.armlinux.org.uk>
References: <20210826121006.685257-1-michael@walle.cc>
 <20210826121006.685257-3-michael@walle.cc>
 <20210826121426.GR22278@shell.armlinux.org.uk>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <ebbb3cb0b07e45cc4171747fae844633@walle.cc>
X-Sender: michael@walle.cc
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 2021-08-26 14:14, schrieb Russell King (Oracle):
> On Thu, Aug 26, 2021 at 02:10:05PM +0200, Michael Walle wrote:
>> +	pdev->dev.coherent_dma_mask = DMA_BIT_MASK(40);
>> +	pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;
> 
> Please use dma_coerce_mask_and_coherent() here instead.

It will be removed altogether in patch 3/3. I just moved the
current code around here. I could drop the code moving in 2/3. I
wasn't sure whats best.

-michael