Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755649AbWLEXtQ (ORCPT ); Tue, 5 Dec 2006 18:49:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756548AbWLEXtQ (ORCPT ); Tue, 5 Dec 2006 18:49:16 -0500 Received: from sj-iport-2-in.cisco.com ([171.71.176.71]:11062 "EHLO sj-iport-2.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755649AbWLEXtP (ORCPT ); Tue, 5 Dec 2006 18:49:15 -0500 X-IronPort-AV: i="4.09,501,1157353200"; d="scan'208"; a="351508595:sNHT43264644" To: Andrew Morton Cc: Andy Fleming , "Maciej W. Rozycki" , Ben Collins , linux-kernel@vger.kernel.org, Linus Torvalds , Jeff Garzik Subject: Re: [PATCH] Export current_is_keventd() for libphy X-Message-Flag: Warning: May contain useful information References: <1165125055.5320.14.camel@gullible> <20061203011625.60268114.akpm@osdl.org> <20061205123958.497a7bd6.akpm@osdl.org> <6FD5FD7A-4CC2-481A-BC87-B869F045B347@freescale.com> <20061205132643.d16db23b.akpm@osdl.org> <20061205135753.9c3844f8.akpm@osdl.org> From: Roland Dreier Date: Tue, 05 Dec 2006 15:49:09 -0800 In-Reply-To: <20061205135753.9c3844f8.akpm@osdl.org> (Andrew Morton's message of "Tue, 5 Dec 2006 13:57:53 -0800") Message-ID: User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.19 (linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 05 Dec 2006 23:49:12.0431 (UTC) FILETIME=[F6F74FF0:01C718C7] Authentication-Results: sj-dkim-7; header.From=rdreier@cisco.com; dkim=pass ( sig from cisco.com/sjdkim7002 verified; ); Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 535 Lines: 13 > But running flush_scheduled_work() from within dev_close() is a very > sensible thing to do, and dev_close is called under rtnl_lock(). I can't argue with that -- this has actually bitten me in the past. Hmm, I'll try to understand why we need rtnl_lock() to cover dev_close... - R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/