Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210826121006.685257-1-michael@walle.cc> <20210826121006.685257-2-michael@walle.cc>
In-Reply-To: <20210826121006.685257-2-michael@walle.cc>
From:   Christian Gmeiner <christian.gmeiner@gmail.com>
Date:   Thu, 26 Aug 2021 14:59:57 +0200
Message-ID: <CAH9NwWcFdt=C=aEp48462wXA6Q47CvTVoRQawyZMuPwwgVzzUA@mail.gmail.com>
Subject: Re: [PATCH 1/3] drm/etnaviv: use PLATFORM_DEVID_NONE
To:     Michael Walle <michael@walle.cc>
Cc:     The etnaviv authors <etnaviv@lists.freedesktop.org>,
        DRI mailing list <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "Lukas F . Hartmann" <lukas@mntre.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Russell King <linux+etnaviv@armlinux.org.uk>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Am Do., 26. Aug. 2021 um 14:10 Uhr schrieb Michael Walle <michael@walle.cc>:
>
> There is already a macro for the magic value. Use it.
>
> Signed-off-by: Michael Walle <michael@walle.cc>

Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>

I will wait for v2 for the rest of the changes to review.

> ---
>  drivers/gpu/drm/etnaviv/etnaviv_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> index 7dcc6392792d..2509b3e85709 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> @@ -653,7 +653,7 @@ static int __init etnaviv_init(void)
>                 if (!of_device_is_available(np))
>                         continue;
>
> -               pdev = platform_device_alloc("etnaviv", -1);
> +               pdev = platform_device_alloc("etnaviv", PLATFORM_DEVID_NONE);
>                 if (!pdev) {
>                         ret = -ENOMEM;
>                         of_node_put(np);
> --
> 2.30.2
>


-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info/privacypolicy