Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] asus-wmi: Fix "unsigned 'retval' is never less than zero"
 smatch warning
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        corentin.chary@gmail.com
Cc:     mgross@linux.intel.com, jdelvare@suse.com, linux@roeck-us.net,
        acpi4asus-user@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        linux-hwmon@vger.kernel.org
References: <1629887822-23918-1-git-send-email-jiapeng.chong@linux.alibaba.com>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <24b6136e-5f76-5d35-0e55-f30699da2417@redhat.com>
Date:   Thu, 26 Aug 2021 15:15:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <1629887822-23918-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 8/25/21 12:37 PM, Jiapeng Chong wrote:
> Eliminate the follow smatch warnings:
> 
> drivers/platform/x86/asus-wmi.c:478 panel_od_write() warn: unsigned
> 'retval' is never less than zero.
> 
> drivers/platform/x86/asus-wmi.c:566 panel_od_write() warn: unsigned
> 'retval' is never less than zero.
> 
> drivers/platform/x86/asus-wmi.c:1451 panel_od_write() warn: unsigned
> 'retval' is never less than zero.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: 98829e84dc67 ("asus-wmi: Add dgpu disable method")
> Fixes: 382b91db8044 ("asus-wmi: Add egpu enable method")
> Fixes: ca91ea34778f ("asus-wmi: Add panel overdrive functionality")
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/x86/asus-wmi.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index cc58118..22af431 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -475,7 +475,7 @@ static int dgpu_disable_write(struct asus_wmi *asus)
>  		return err;
>  	}
>  
> -	if (retval > 1 || retval < 0) {
> +	if (retval > 1) {
>  		pr_warn("Failed to set dgpu disable (retval): 0x%x\n", retval);
>  		return -EIO;
>  	}
> @@ -563,7 +563,7 @@ static int egpu_enable_write(struct asus_wmi *asus)
>  		return err;
>  	}
>  
> -	if (retval > 1 || retval < 0) {
> +	if (retval > 1) {
>  		pr_warn("Failed to set egpu disable (retval): 0x%x\n", retval);
>  		return -EIO;
>  	}
> @@ -1448,7 +1448,7 @@ static int panel_od_write(struct asus_wmi *asus)
>  		return err;
>  	}
>  
> -	if (retval > 1 || retval < 0) {
> +	if (retval > 1) {
>  		pr_warn("Failed to set panel overdrive (retval): 0x%x\n", retval);
>  		return -EIO;
>  	}
>