Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mfd: intel_pmt: Only compile on x86
To:     Prarit Bhargava <prarit@redhat.com>, linux-kernel@vger.kernel.org
Cc:     Lee Jones <lee.jones@linaro.org>,
        "David E . Box" <david.e.box@linux.intel.com>
References: <20210825125735.621799-1-prarit@redhat.com>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <b075d481-f1a3-22d5-24b7-0b170d2908a1@redhat.com>
Date:   Thu, 26 Aug 2021 15:19:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210825125735.621799-1-prarit@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 8/25/21 2:57 PM, Prarit Bhargava wrote:
> The intel_pmt driver shows up as a compile option for all arches but is
> 32-bit and 64-bit x86 specific.
> 
> Add a CONFIG dependency on X86 for intel_pmt.
> 
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: David E. Box <david.e.box@linux.intel.com>
> Cc: Hans de Goede <hdegoede@redhat.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6a3fd2d75f96..0f12b00955b4 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -676,7 +676,7 @@ config MFD_INTEL_PMC_BXT
>  
>  config MFD_INTEL_PMT
>  	tristate "Intel Platform Monitoring Technology (PMT) support"
> -	depends on PCI
> +	depends on X86 && PCI
>  	select MFD_CORE
>  	help
>  	  The Intel Platform Monitoring Technology (PMT) is an interface that
>