Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6d8179f45f7139ecc8172c2d2c4988b943393c1e.camel@perches.com>
Subject: Re: [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"
From:   Joe Perches <joe@perches.com>
To:     Colin King <colin.king@canonical.com>,
        Raju Rangoju <rajur@chelsio.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 26 Aug 2021 07:50:17 -0700
In-Reply-To: <20210826120108.12185-1-colin.king@canonical.com>
References: <20210826120108.12185-1-colin.king@canonical.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 2021-08-26 at 13:01 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There are spelling mistakes in dev_err and dev_info messages. Fix them.
[]
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
[]
> @@ -120,7 +120,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
> ?				write_unlock_bh(&ctbl->lock);
> ?1 file changed, 2 insertions(+), 2 deletions(-)
> ?				dev_err(adap->pdev_dev,
> ?					"CLIP FW cmd failed with error %d, "
> -					"Connections using %pI6c wont be "
> +					"Connections using %pI6c won't be "
> ?					"offloaded",
> ?					ret, ce->addr6.sin6_addr.s6_addr);
> ?				return ret;
> @@ -133,7 +133,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
> ?	} else {
> ?		write_unlock_bh(&ctbl->lock);
> ?		dev_info(adap->pdev_dev, "CLIP table overflow, "
> -			 "Connections using %pI6c wont be offloaded",
> +			 "Connections using %pI6c won't be offloaded",
> ?			 (void *)lip);

This is an unnecessary cast.
And these could coalesce the format fragments and add newlines too.