Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp637213pxb; Thu, 26 Aug 2021 10:46:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcRvrKu5JcEVl0Lt7J6aof2LDHLvP9FBB1u3vh8iRQ4/gmiu255vehIP977NIwEo04By4H X-Received: by 2002:a05:6402:1e8e:: with SMTP id f14mr479977edf.15.1629999980936; Thu, 26 Aug 2021 10:46:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629999980; cv=none; d=google.com; s=arc-20160816; b=HyciqA7zJ6t+MJkqBwnMWGvSn6K1MBZRzTGMpFAIRPMtPbcbv4GwPxpNexd95lQRpu hxzjuk5Tyqnl4OrPuBMRuIwfsByDjMw5EWTctpFp7393tj/2SaLPQOtaAY1CmZEJATYS lTMSsS5BJuLd3OIyLV7di/+yCire/AyTi7+fJT5EOAwdwfNypDOkFa0HExXThElFtzTA Lf4YaTJ3kEmCkh2Q0bhE3w1iiupf0HTNXiXCvpn1NEgHwBpyxPJ4eEsAh7qQgzJljOSz GhHoK3ibtEYNnNiEx5fritdzr4y8negSfiprHmtVFOk1FxS4PE0BsdIiiZip1w7Kel+C N/cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=1MY4FXuyrHIHxnVsVGM3kgnjUslCMqrCLSsSFVBxeBo=; b=TyPbrvboMWq72Y8hEg8ttJXghXzMqi3wk0yKBUCtITYPBPOT9niJR6JBJqrKajLuR8 TLfj2JRl9z6PzeC7lnFCg+/md+LYTQXltdq6BxtseoC5XnSO0nz1rMO7kLK1toFmIyBo rnSDEHcJbaQDc4Q+vOtsrLYu5n9ioMtYfK4qZBOd9H4cv0FzH/P0XHMo6qgsX+2eTxZb cmFE6Dx6EeidQk9nTUy0Py1C7yfcBDHmmZazxTauc/HVcXgGow9Y3h/yR1tX2WSso+Pt GN48QSgyZUbumC6BPz5dQ3IiUkwDKCMrie3QhcyXCo8Vao84bWkJmrFRwkuPHK232d/Q vhyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@itfac-mrt-ac-lk.20150623.gappssmtp.com header.s=20150623 header.b=t8dUDFPO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g19si4006213edu.345.2021.08.26.10.45.42; Thu, 26 Aug 2021 10:46:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@itfac-mrt-ac-lk.20150623.gappssmtp.com header.s=20150623 header.b=t8dUDFPO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232159AbhHZRoI (ORCPT + 99 others); Thu, 26 Aug 2021 13:44:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231648AbhHZRoH (ORCPT ); Thu, 26 Aug 2021 13:44:07 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D71BC0613C1 for ; Thu, 26 Aug 2021 10:43:20 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id y23so3680444pgi.7 for ; Thu, 26 Aug 2021 10:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itfac-mrt-ac-lk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=1MY4FXuyrHIHxnVsVGM3kgnjUslCMqrCLSsSFVBxeBo=; b=t8dUDFPO19amoXQ1mSRTnweDzzs8zreWVh0cYacCz/AHe7PCKkZUn5dDEA/Pc4sYhE tEgQhtPO0QJ2XVf/USe8iMJVyOTWNXjMvfwRFNwvfLqrRUNsJmBkModhB6VihfNo05nu zsWDYunlUA5mVLZAMTDi2mxN+kwVqCEm4nDSnAqqMow+/qS1B+piiV/7L/vkNFCME3DP T9PgHvBYh0ysBYSrBn0LBpJXWi37eisZ3OrjijoTllll73yBFWWwh0xGLVbiwA8dGEew SauhREsRY04hJwV7793/L0Aixe1DNOPvqkk/mVgt/9cI1+W070k3I+wxwiirYCBaBIMq CTXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1MY4FXuyrHIHxnVsVGM3kgnjUslCMqrCLSsSFVBxeBo=; b=uPg0nWuIJRuu/hF0xjReyIc3S/F5X4AzTps7uEcqf+OGI9HLOx3A8JjaxO92o5LP0b 6+LXKPqbdMdkRbty6LCbkLNkk/aFu6QMJ8f9TMHSN+kivEeKF0aVFjEDpcBS3tDFLHi1 cPQzuiep1l2Vc6rByOvwTLdDj53mKW7mQSefiYJPOevzzybj0raH9OF/T44UqjBMlNb7 NmdHUWZzRsbcDH7Kus+CHP1h+Np/0qr0IpPV9gWo9icdu6JT//QD16+rVGDX6k+ZEDce x41iw8I6Lmi4Gw/Dqb10c9+Uwb7/iJTqAoC6AaESO7bMA78kyCR40arRdgjNSH2UyrI5 26ow== X-Gm-Message-State: AOAM532vcfNMYxFeb11aAC6lanuuObin11MvCmYdaOe7QKQYK5g0Br5Y /U7Wvd+4vbxcXBHmqNGOIK8BT6D3gQfG X-Received: by 2002:a62:1a03:0:b029:3e0:30aa:5172 with SMTP id a3-20020a621a030000b02903e030aa5172mr4732412pfa.69.1629999799521; Thu, 26 Aug 2021 10:43:19 -0700 (PDT) Received: from localhost.localdomain ([175.157.109.217]) by smtp.gmail.com with ESMTPSA id u6sm4125224pgr.3.2021.08.26.10.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 10:43:19 -0700 (PDT) From: "F.A.Sulaiman" To: axboe@kernel.dk Cc: "F.A.Sulaiman" , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ATA:libata-pmp: fix warn: missing error code Date: Thu, 26 Aug 2021 23:13:01 +0530 Message-Id: <20210826174301.21255-1-asha.16@itfac.mrt.ac.lk> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org smatch reported 'sata_pmp_eh_recover() warn: missing error code 'rc''. This patch resolve it by adding I/O error code to 'rc'. Signed-off-by: F.A. SULAIMAN --- drivers/ata/libata-pmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c index ba7be3f38617..2ea7b9986f4e 100644 --- a/drivers/ata/libata-pmp.c +++ b/drivers/ata/libata-pmp.c @@ -977,6 +977,7 @@ static int sata_pmp_eh_recover(struct ata_port *ap) ata_link_warn(pmp_link, "failed to disable NOTIFY (err_mask=0x%x)\n", err_mask); + rc = -EIO; goto pmp_fail; } } -- 2.17.1