Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp652689pxb; Thu, 26 Aug 2021 11:10:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzXmNJs8KRpV1Ep2JK02yrOSGqWo4Itfz0PudW7OlOMI+nJs23/9iE4tF7231Nc723oVIe X-Received: by 2002:a5d:9617:: with SMTP id w23mr3999171iol.115.1630001402868; Thu, 26 Aug 2021 11:10:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630001402; cv=none; d=google.com; s=arc-20160816; b=aRgyOlHfYtnM1O5MjW89opRaYZKkRMlYx3eTCyGVcP0md7YPxGAEtLkGKeX+SthQoc p3/265u6Lw1mjaBMkUd9/5Tlz6dbJFJQbEc8tFWOlxV+xITOnqyoMR9ZNj2ivTtIIImI uFSUdR/wNim8hrEam879eKseCupTZoQgfU9sAJQoPJGr6Pz8255191Mlxd3XjEQ7rpHa DAlCqQxAw0fWRJFOxc9PlGmUafZjtvuMcmBrjEQLipPVsicccTUcfREDdgYtezKpB36x IHkyB4BmU27yZrjQLj4wAKtZ+WonTG9brs2Isof7fGJHALTXIYpdE474ZwnrrCxYPgqF 9neA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=jy6kuEa6qOgtVcIiHcL8rg+bn6K8NFztM/6FPGA8TH0=; b=MEbwgTmDEMHUAl188x/SebiKuE9fk5U5gWR1VWtQQTTzFicMriA5TeBL7uGfPEFnoj pkpCnbP6ZlpozZsNisQIoylMj9aZXghPjVANrnabJdoRzzsMqYRMRzb3L3kyA+hqtyOG +glwajUv+q+t8VTBNppHqtMC9Dcz23Z1xJR4j4AZIKc8T7eGy7Kacg67RXa1Jh3/KlOm yU4kaPy03LpKNBYBsRFOFcPDhQWepTK7DNRPuzA7d6iSCGzFmR3ZW92jl5igb/KtgaHC /cEQ2WQ/39UmOUM+tJlpW8O1yv8abkJ3bZE7rRoCT8tWlUCtwhQb6Jjk0LwfmmfbrwCZ kEEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="cOVMuHR/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s10si3378714ioo.6.2021.08.26.11.09.48; Thu, 26 Aug 2021 11:10:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="cOVMuHR/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231648AbhHZSJo (ORCPT + 99 others); Thu, 26 Aug 2021 14:09:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229733AbhHZSJm (ORCPT ); Thu, 26 Aug 2021 14:09:42 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF7DBC061757 for ; Thu, 26 Aug 2021 11:08:54 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id j18so4844556ioj.8 for ; Thu, 26 Aug 2021 11:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jy6kuEa6qOgtVcIiHcL8rg+bn6K8NFztM/6FPGA8TH0=; b=cOVMuHR/jcS4F7qoAfsqLFcmg6fAf3mJeeBFe3SuigOc873b4njVi0bY+8ShjxHOla wEXxYRLn03hQXt7bL0bhzXJ/YWy0n7GCBeTq0P2rKE+9SZTdDphev2LQdCbCv3OQB+Rm MOdPQJzIyaQ0sfzXZhP6JjPqS7jB/I68vMLtk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jy6kuEa6qOgtVcIiHcL8rg+bn6K8NFztM/6FPGA8TH0=; b=hwJwT+hR/TiUufVbnMKa7IqL+8V1E8bX30ZKxqWdtZb6XG0Nz4/cEUmQSQyocQD862 KBqy8xup/hEgHQ62g+IYpsMUsGOciNM0IvqlbAJd6pKHDpi9qfxLU0TZbKx/Qq1w9mJT ay4u0Nu9oP/C2LTveEIwEnZEmmV3JhVnYIf84kqD27uwE+lGoaCJZ4jmKoCR6wgGWrHN A7jh2upDnlpUeZiev98qSsfbM62kgnU8pS27PWGAYdTppOHJJaOzpRkOOVs0rieN4mgs 17T0Af9ywUIoTPgOja4CK1z8jocPeYKgDJ/sBX6qrv1nvelxG7X/LFxo7AYUOu2deDr5 Rd0g== X-Gm-Message-State: AOAM530uuQVJM22xe8rhz2HD2otp03kVOss62Sx57Bkn/LM99/hqgJ/Q afsg0b00BmxmLo+TAfIgwRnPrjLqvlT6kw== X-Received: by 2002:a5d:9e49:: with SMTP id i9mr4058232ioi.125.1630001333919; Thu, 26 Aug 2021 11:08:53 -0700 (PDT) Received: from mail-il1-f176.google.com (mail-il1-f176.google.com. [209.85.166.176]) by smtp.gmail.com with ESMTPSA id k7sm1847298iok.22.2021.08.26.11.08.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Aug 2021 11:08:53 -0700 (PDT) Received: by mail-il1-f176.google.com with SMTP id x5so4205968ill.3 for ; Thu, 26 Aug 2021 11:08:52 -0700 (PDT) X-Received: by 2002:a05:6e02:964:: with SMTP id q4mr3649001ilt.229.1630001332199; Thu, 26 Aug 2021 11:08:52 -0700 (PDT) MIME-Version: 1.0 References: <20210824181140.v2.1.I8ead7431357409f2526e5739ec5bc3ddfd242243@changeid> In-Reply-To: <20210824181140.v2.1.I8ead7431357409f2526e5739ec5bc3ddfd242243@changeid> From: Doug Anderson Date: Thu, 26 Aug 2021 11:08:40 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] drm/bridge: parade-ps8640: Reorg the macros To: Philip Chen Cc: LKML , Stephen Boyd , Andrzej Hajda , Daniel Vetter , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Neil Armstrong , Robert Foss , dri-devel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Aug 24, 2021 at 6:12 PM Philip Chen wrote: > > Reorg the macros as follows: > (1) Group the registers on the same page together. > (2) Group the register and its bit operation together while indenting > the macros of the bit operation with one space. > > Also fix a misnomer for the number of mipi data lanes. > > Signed-off-by: Philip Chen > --- > > Changes in v2: > - Fix the double sign-off lines > > drivers/gpu/drm/bridge/parade-ps8640.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) Pushed to drm-misc-next with Sam's Ack and Stephen's review. 28210a3f5412 drm/bridge: parade-ps8640: Reorg the macros -Doug