Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1067466pxb; Thu, 26 Aug 2021 23:57:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDlufmdQZUtNZeTxK8WznsPwNvc8l4ByClf8QbWUn2uIWHZ5Nr+Fw0EWpCgCmhPeZu+2jI X-Received: by 2002:a05:6638:370a:: with SMTP id k10mr6882524jav.20.1630047465351; Thu, 26 Aug 2021 23:57:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630047465; cv=none; d=google.com; s=arc-20160816; b=b0xG+uaAr+JLagtyZvfNHuYKztOdrdHoL2PkR6ahoAgQDAjlKxsfThXSJ1iC/y3y0J t6q1hw+8BFcv2ODrAB14Gq2qvAlez0tx4fwXbbEzpLUeEqefulucboX7UWVhDD2vWsDB P9hqr56fUVax7AyUmVD6mD2Dduk6/coe4d/9CQpOqpWXHBVeqMttURYKBK3VIEs1bsoi ilXvrEN4SGndf4UHSY+ucxWHBzahbpbiKs0EUehWCrHPTdadARw89WBJLhkVv5ID/Onl 2QpHp+sf9O1kTSm/zv6+ivTpHiqbPSjDuAlXK44MHbdvu157MYtH4iWKjh9pqTA6EoQd hSIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YMwUrGqHfFR01a2MXA7EMX9IauRhE/U4j2NgGaIJtog=; b=fa6M3+R2NWo50ileNRG7PVdCxUfKQZ8sn4QXh7NoBrqCxU9tkmSNWsaOY6I3JTyLif 45oX3Sobw9QoBeGTFBqg6wftDxx3diWO+5odC1BYgYClPE+jSYC4CqmHlvuBH7TChhHK H2++516guwj927pnnUp7flyALFYeGE4L4ydPwu6AMYPobwVcl2su2llgvn4IbdNa0bi7 dZGGtNYQCFDoJUobZgToYxYRGSHTKQR6qwT4ZPnSU69afxl7vFqWbMUtqHQF2dRMDfDg P0lPfIMV39vAbLp6MsTRdSoD3fIYlmBYEhagBK2eB6MZm2cdSs4QolLG6zmKckFyLD8j ZQ4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fVQy2z86; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e201si4958547jac.105.2021.08.26.23.57.34; Thu, 26 Aug 2021 23:57:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fVQy2z86; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244234AbhH0G5f (ORCPT + 99 others); Fri, 27 Aug 2021 02:57:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:53456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243036AbhH0G52 (ORCPT ); Fri, 27 Aug 2021 02:57:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B946D60EE9; Fri, 27 Aug 2021 06:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630047400; bh=ny6f4lzmpCGyhd2J7fXTQxRESmvT2VU0QnnckaPrpJg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fVQy2z86G0kW+PGWN2dTYEURNhA4ZL/k3fZGCbh11js3hIWIpfcn1aMNYLuhKNyCk +bFOhRzhHaW2OPM498UQDN4zRH6dXZjhuLtk+aOrLxYTQK7QloMJXg2qAhlL8P4R6k pVdJ2pCzCDuMSsLvdyygwb1j2TPOMNUmjC6YIrMU= Date: Fri, 27 Aug 2021 08:56:33 +0200 From: Greg KH To: Kate Hsuan Cc: Jens Axboe , Hans de Goede , Damien Le Moal , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Martin K . Petersen" Subject: Re: [PATCH v2 1/1] libata: libata: add ATA_HORKAGE_NO_NCQ_TRIM for Samsung 860 and 870 SSDs Message-ID: References: <20210827053344.15087-1-hpa@redhat.com> <20210827053344.15087-2-hpa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210827053344.15087-2-hpa@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 27, 2021 at 01:33:44AM -0400, Kate Hsuan wrote: > A flag ATA_HORKAGE_NONCQ_ON_ASMEDIA_AMD_MARVELL is added to disable NCQ > on AMD/MAREL/ASMEDIA chipsets. > > Samsung 860/870 SSD are disabled to use NCQ trim functions but it will > lead to performace drop. From the bugzilla, we could realize the issues > only appears on those chipset mentioned above. So this flag could be > used to only disable NCQ on specific chipsets. > > Fixes: ca6bfcb2f6d9 ("libata: Enable queued TRIM for Samsung SSD 860") > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=203475 > Signed-off-by: Hans de Goede > Reviewed-by: Martin K. Petersen > Signed-off-by: Kate Hsuan > --- > drivers/ata/libata-core.c | 37 ++++++++++++++++++++++++++++++++----- > include/linux/libata.h | 3 +++ > 2 files changed, 35 insertions(+), 5 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.