Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     linux-staging@lists.linux.dev,
        Krish Jain <krishjain02939@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Declare the file_operations struct as const
Date:   Fri, 27 Aug 2021 09:48:04 +0200
Message-ID: <1742120.GgyQvu0Ciu@localhost.localdomain>
In-Reply-To: <3634721.RBzQ2xsved@localhost.localdomain>
References: <CAPGkw+x+B1731SL=afoSKiWwH-n-FA5YJ+WOwYdv8iyFhWk1zA@mail.gmail.com> <3634721.RBzQ2xsved@localhost.localdomain>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Friday, August 27, 2021 8:49:30 AM CEST Fabio M. De Francesco wrote:
> On Friday, August 27, 2021 3:59:28 AM CEST Krish Jain wrote:
> >  From: Krish Jain <krishjain02939@gmail.com>
> > 
> > Declare the file_operations struct as const as done elsewhere in the
> > kernel, as there are no modifications to its fields.
> > 
> > Signed-off-by: Krish Jain <krishjain02939@gmail.com>
> > ---
> > []
> Are you sure that it works? I wouldn't be.
> You didn't build this file. Please build your changes before submitting patches.
> 
> Furthermore, please always rebase to the current version of the staging tree.
> 
> Finally, please use the class modifier "static" as the first keyword of a declaration/definition
> as it is done everywhere in the kernel (see "grep -rn "static const" drivers/staging/" and
> then switch to "const static" and read the output).

Please don't misunderstand me: as far as I can see this is your first patch and 
(I'm pretty sure I can speak for everyone else about this) you are very welcome 
to staging and to kernel hacking :)

However, before posting further works, you'd better read at least the following 
documents:

https://www.kernel.org/doc/html/latest/process/4.Coding.html
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

And please don't forget to always CC linux-kernel@vger.kernel.org.

Have a nice time with kernel hacking.

Thanks,

Fabio