Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 0/6] staging: r8188eu: avoid uninit value bugs
To:     Kari Argillander <kari.argillander@gmail.com>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, straube.linux@gmail.com,
        fmdefrancesco@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <CAA=Fs0=gX66TW3qoHYWcoSsvai6YZn=U81a34V45oij7NrMJrQ@mail.gmail.com>
 <cover.1629789580.git.paskripkin@gmail.com>
 <20210827074932.2qkpvmakwqqxo6hc@kari-VirtualBox>
From:   Pavel Skripkin <paskripkin@gmail.com>
Message-ID: <ae721297-68ae-dde6-d9e5-5963ebcece07@gmail.com>
Date:   Fri, 27 Aug 2021 10:52:59 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210827074932.2qkpvmakwqqxo6hc@kari-VirtualBox>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/27/21 10:49 AM, Kari Argillander wrote:
> On Tue, Aug 24, 2021 at 10:25:45AM +0300, Pavel Skripkin wrote:
>> Hi, Greg, Larry and Phillip!
>> 
>> I noticed, that new staging driver was added like 3 weeks ago and I decided
>> to look at the code, because drivers in staging directory are always buggy.
>> 
>> The first thing I noticed is *no one* was checking read operations result, but
>> it can fail and driver may start writing random stack values into registers. It
>> can cause driver misbehavior or device misbehavior.
>> 
>> To avoid this type of bugs, i've changed rtw_read* API. Now all rtw_read
>> funtions return an error, when something went wrong with usb transfer.
>> 
>> It helps callers to break/return earlier and don't write random values to
>> registers or to rely on random values.
>> 
>> 
>> v2 -> v3:
> 
> Hi Pavel.
> 
> If v4 is needed can you please send it without replying to old message.
> This thread is so hard to follow because always new version is answer to
> old subject. This depens a little bit how you setup your email, but some
> of us is grouping all emails in same thread and this thread is out of
> control :D
> 

Hi, Kari!

v4 will be posted soon, yep. I will post v4 as separate thread :) It's 
unreal to follow the discussion for sure. I often spend about a minute 
to find an actual mail to reply xd


With regards,
Pavel Skripkin