Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1124173pxb; Fri, 27 Aug 2021 01:35:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9LYoqnXRILxqQX2Es2VOkJEUgd72qb899c0RFVBU8ojKc7CXrXcT820NW+mbhjaHvSXdK X-Received: by 2002:a05:6e02:eb0:: with SMTP id u16mr5808497ilj.303.1630053308497; Fri, 27 Aug 2021 01:35:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630053308; cv=none; d=google.com; s=arc-20160816; b=kw0gCvVv8Wycx0rjfziT1zg8IQ+PjUN7DRT1WahGW6LdBf/a7v6rBBNEl1r8leFQ52 FhNL0GLZ2DGsDJcD2Fktqo3Kz1bv+h7tkz2ULyxwpuCv9l+WPAvrVSiEvpVUY6PyaOo6 BDSKL9gsoSY1m+WTulOfx3KQGCloo8WmIfoVQV/javPu9l+UqipEyE2HQyvbGzugoSHd YQtAp1AHI8jAAGI73dbs7rztavm5QVd3GOUQbO9EoCTauv4HJwHn75sGwh0iF7JsBOHD W5NYb9zOC18zg6fO5Xmq6aMO8xDZgQit2BNsD/5RbWh+rFxtl80y0zMbQ9BlZsuAYafl 3cKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=BFcFyUY05AEKiHnIN3FmFc6C7KGm3HKkB/7qM14Nh0o=; b=hriAAhQyIrUUdc3tRawsnOMJcHw7i3vYgpMLsYVpMyAihQJk44ltS3Uzo/TKMPgwp/ cbDLHzgaTtJ3q0ASyH7sPjyuc71BJXOvm89He9ds8CRbZ8BpZvdpTT/eZRddOlC01P++ +eOQU8qRrvEuIjbpkX3kYR2JyyII8Lt3STQz+IbrAdoC8tAj+UWofSfmNZ+AHxYb9GTz x4wbovuUQoIuxmOevNdHKEzHYxuZrqyoMYZU7RHzYF4GMb5O9uqBK7mKeuEfUrDPzPCf WWN7NB7NIewRkgiH3xQihXoJWUFYm7A/0lq4kFuih04RoPfExwRD6z9luW76tqyNWcrO 0vbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c203si6365342iof.54.2021.08.27.01.34.57; Fri, 27 Aug 2021 01:35:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244603AbhH0IfE (ORCPT + 99 others); Fri, 27 Aug 2021 04:35:04 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.85.151]:27397 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244602AbhH0Ie5 (ORCPT ); Fri, 27 Aug 2021 04:34:57 -0400 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-282-cY9NIgxAN6addO80KQbTFA-1; Fri, 27 Aug 2021 09:34:06 +0100 X-MC-Unique: cY9NIgxAN6addO80KQbTFA-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Fri, 27 Aug 2021 09:34:04 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.023; Fri, 27 Aug 2021 09:34:04 +0100 From: David Laight To: 'Peter Collingbourne' CC: "David S. Miller" , Jakub Kicinski , Colin Ian King , Cong Wang , Al Viro , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: RE: [PATCH] net: don't unconditionally copy_from_user a struct ifreq for socket ioctls Thread-Topic: [PATCH] net: don't unconditionally copy_from_user a struct ifreq for socket ioctls Thread-Index: AQHXmhmeusqat7DUPUKEZ8XxUHnOHquFbtgQgACyTQCAAOW6wA== Date: Fri, 27 Aug 2021 08:34:04 +0000 Message-ID: References: <20210826012722.3210359-1-pcc@google.com> <11f72b27c12f46eb8bef1d1773980c54@AcuMS.aculab.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org RnJvbTogUGV0ZXIgQ29sbGluZ2JvdXJuZQ0KPiBTZW50OiAyNiBBdWd1c3QgMjAyMSAyMDo0Ng0K Li4uDQo+ID4gVGhlIG90aGVyIHNhbmUgdGhpbmcgaXMgdG8gY2hlY2sgX0lPQ19TSVpFKCkuDQo+ ID4gU2luY2UgYWxsIHRoZSBTSU9DeHh4eCBoYXZlIGEgY29ycmVjdCBfSU9DX1NJWkUoKSB0aGF0 IGNhbiBiZQ0KPiA+IHVzZWQgdG8gY2hlY2sgdGhlIHVzZXIgY29weSBsZW5ndGguDQo+ID4gKFVu bGlrZSBzb2NrZXQgb3B0aW9ucyB0aGUgY29ycmVjdCBsZW5ndGggaXMgYWx3YXlzIHN1cHBsaWVk Lg0KPiANCj4gRldJVywgaXQgZG9lc24ndCBsb29rIGxpa2UgYW55IG9mIHRoZW0gaGF2ZSB0aGUg X0lPQ19TSVpFKCkgYml0cyBzZXQsDQo+IHNvIHRoYXQgd29uJ3Qgd29yay4gX0lPQ19UWVBFKCkg c2VlbXMgYmV0dGVyIGFueXdheS4NCg0KTGludXMgbXVzdCBoYXZlIHN0b2xlbiB0aG9zZSBkZWZp bml0aW9ucyBmcm9tIFNWU1Ygbm90IG9uZSBvZiB0aGUgQlNEcy4NClRoZSBCU0QncyBzdGFydGVk IHVzaW5nIHRoZSBoaWdoIDE2IGJpdHMgd2hlbiB0aGV5IG1vdmVkIHRvIDMyYml0Lg0KDQpTb21l dGhpbmcgSSd2ZSB3cml0dGVuIGtlcm5lbCBjb2RlIGZvciByZXF1aXJlZCB0aG9zZSBiaXRzIGJl IHNldA0KYW5kIHdvdWxkIHRoZW4gZG8gdGhlIHVzZXIgY29waWVzIGluIHRoZSBzeXNjYWxsIGVu dHJ5IHBhdGhzLg0KSXQgd29uJ3QgYmUgU1lTViBiZWNhdXNlIEkgdXNlZCAzIGNoYXJhY3RlciAn dHlwZScgZmllbGRzIG9uIHRoYXQuDQpXaW5kb3dzIGRvZXMgZG8gdGhlIGNvcGllcyAtIGJ1dCBp cyBlbnRpcmVseSAnbm90IHF1aXRlJyBkaWZmZXJlbnQuDQpTbyBpdCBtdXN0IGhhdmUgYmVlbiBO ZXRCRFNELg0KDQoJRGF2aWQNCg0KLQ0KUmVnaXN0ZXJlZCBBZGRyZXNzIExha2VzaWRlLCBCcmFt bGV5IFJvYWQsIE1vdW50IEZhcm0sIE1pbHRvbiBLZXluZXMsIE1LMSAxUFQsIFVLDQpSZWdpc3Ry YXRpb24gTm86IDEzOTczODYgKFdhbGVzKQ0K