Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAPGkw+x+B1731SL=afoSKiWwH-n-FA5YJ+WOwYdv8iyFhWk1zA@mail.gmail.com>
 <3634721.RBzQ2xsved@localhost.localdomain> <1742120.GgyQvu0Ciu@localhost.localdomain>
In-Reply-To: <1742120.GgyQvu0Ciu@localhost.localdomain>
From:   Krish Jain <krishjain02939@gmail.com>
Date:   Fri, 27 Aug 2021 10:50:52 +0200
Message-ID: <CAPGkw+yJ=V0OwFE+uqCeWWS8JbJD=YBE3+Uk-OKpmHRnvSTh+A@mail.gmail.com>
Subject: Re: [PATCH] Declare the file_operations struct as const
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi, yes, this is my first time programming at this low level. And yes,
I read both docs now. Furthermore the issue is that my current
hardware can't handle building the kernel, it barely managed to
survive the first build after 2 hours so I don't know how I can. If I
change it to static const would it fix the issue and build
successfully?  If not what would be the error message, then I can
debug. Thanks

On Fri, Aug 27, 2021 at 9:48 AM Fabio M. De Francesco
<fmdefrancesco@gmail.com> wrote:
>
> On Friday, August 27, 2021 8:49:30 AM CEST Fabio M. De Francesco wrote:
> > On Friday, August 27, 2021 3:59:28 AM CEST Krish Jain wrote:
> > >  From: Krish Jain <krishjain02939@gmail.com>
> > >
> > > Declare the file_operations struct as const as done elsewhere in the
> > > kernel, as there are no modifications to its fields.
> > >
> > > Signed-off-by: Krish Jain <krishjain02939@gmail.com>
> > > ---
> > > []
> > Are you sure that it works? I wouldn't be.
> > You didn't build this file. Please build your changes before submitting patches.
> >
> > Furthermore, please always rebase to the current version of the staging tree.
> >
> > Finally, please use the class modifier "static" as the first keyword of a declaration/definition
> > as it is done everywhere in the kernel (see "grep -rn "static const" drivers/staging/" and
> > then switch to "const static" and read the output).
>
> Please don't misunderstand me: as far as I can see this is your first patch and
> (I'm pretty sure I can speak for everyone else about this) you are very welcome
> to staging and to kernel hacking :)
>
> However, before posting further works, you'd better read at least the following
> documents:
>
> https://www.kernel.org/doc/html/latest/process/4.Coding.html
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>
> And please don't forget to always CC linux-kernel@vger.kernel.org.
>
> Have a nice time with kernel hacking.
>
> Thanks,
>
> Fabio
>
>