Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1156639pxb; Fri, 27 Aug 2021 02:33:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFBAU3id4pMbb1ayP/BP9YqYmGVSwh8lABZNYZWcYWXtiINgy8SKMF2rBtWtTbi5FZr5tF X-Received: by 2002:a02:ac11:: with SMTP id a17mr3938337jao.100.1630056822206; Fri, 27 Aug 2021 02:33:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630056822; cv=none; d=google.com; s=arc-20160816; b=Va0wGjeLcWfR+xORvsX1W6c77nwS5gcqC32ywfWbX2vI/Y9MIhsFkrlBueIHgy86/i cow1+3ZugKRtK5nq8m5PL1NMfEGfY7VfhmOzXIXEBGYVhGZbu6sg3fYgZRCYv6o9COGr MVig/WqfXKxpUnpf/56LLFoDFjjqW5sWSoKE4iHXtoX3/kW9zW7fQ+oByUFfY3Q1frJ6 frrCvBKH8zrqM/xvJy0hPJTczfjUtIHQryEje0PQzhlAkqV+2NWyNPPDp++qKVZ7knal DJOmK9eK4OJ9Nn6czUONMF0CUSS3PmE+tTz+2xNwAROzkbKkMa/mcGjH0GBLCohX5LQs OiDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=l8Lj8Ero8rnq4ahAibx9RPUt+ErBzpB7uy4V0bK1Hog=; b=Ti2cODVNpNc8UXsju8siTxMRdlTTNMo0P4kXMYlw0XFB3iTQsXIxAsTuWLRShi6F8z QRsIOTPCaQoqeKUyR/R/460UcTkHoXRyg3J1LsN/6hy4lj6E+M7yaB0CbLYanni3EZGx VHVxKmbyIguc9a0tbWkWjCNpsSLF12utPqMmpm68wuxV9BOI225cwrqdGjSYGXJqPOCm to4yUaSZCiPtxgoyflM8kMAcxajOD9y2dPciPnqIGE6KJnqee2pHJbzVbLGptFN0S8xF +7Nioo7+pwPG1PpV5dNRpslMEdREam0kJyicel+nHyQOnt69l0kJhkD3XRzN2AEGd3/V 3UjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o3si5323031ils.62.2021.08.27.02.33.31; Fri, 27 Aug 2021 02:33:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244892AbhH0Jd3 (ORCPT + 99 others); Fri, 27 Aug 2021 05:33:29 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:15261 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244725AbhH0JdH (ORCPT ); Fri, 27 Aug 2021 05:33:07 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Gwvcb6txyz87pk; Fri, 27 Aug 2021 17:31:59 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 27 Aug 2021 17:32:16 +0800 Received: from localhost.localdomain (10.67.165.24) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 27 Aug 2021 17:32:16 +0800 From: Guangbin Huang To: , CC: , , , Subject: [PATCH net-next 3/8] net: hns3: remove redundant param mbx_event_pending Date: Fri, 27 Aug 2021 17:28:19 +0800 Message-ID: <1630056504-31725-4-git-send-email-huangguangbin2@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1630056504-31725-1-git-send-email-huangguangbin2@huawei.com> References: <1630056504-31725-1-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggemi759-chm.china.huawei.com (10.1.198.145) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Li This patch removes the redundant param mbx_event_pending. Signed-off-by: Peng Li Signed-off-by: Guangbin Huang --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h | 1 - drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c | 12 ------------ 2 files changed, 13 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h index 73e8bb5efc30..1de8e2deda15 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h @@ -317,7 +317,6 @@ struct hclgevf_dev { struct hclgevf_mac_table_cfg mac_table; - bool mbx_event_pending; struct hclgevf_mbx_resp_status mbx_resp; /* mailbox response */ struct hclgevf_mbx_arq_ring arq; /* mailbox async rx queue */ diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c index b339b9bc0625..50309506bb60 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c @@ -236,13 +236,6 @@ void hclgevf_mbx_handler(struct hclgevf_dev *hdev) case HCLGE_MBX_LINK_STAT_MODE: case HCLGE_MBX_PUSH_VLAN_INFO: case HCLGE_MBX_PUSH_PROMISC_INFO: - /* set this mbx event as pending. This is required as we - * might loose interrupt event when mbx task is busy - * handling. This shall be cleared when mbx task just - * enters handling state. - */ - hdev->mbx_event_pending = true; - /* we will drop the async msg if we find ARQ as full * and continue with next message */ @@ -298,11 +291,6 @@ void hclgevf_mbx_async_handler(struct hclgevf_dev *hdev) u8 flag; u8 idx; - /* we can safely clear it now as we are at start of the async message - * processing - */ - hdev->mbx_event_pending = false; - tail = hdev->arq.tail; /* process all the async queue messages */ -- 2.8.1