Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1157592pxb; Fri, 27 Aug 2021 02:35:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4XynZdi+XgpVTSzVjZpYKDekRyou/EaUyMgCpmy6hKo7zKx5gTb08Hp2jr5LkYj4tiqFa X-Received: by 2002:a17:906:f8c4:: with SMTP id lh4mr8975041ejb.542.1630056923336; Fri, 27 Aug 2021 02:35:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630056923; cv=none; d=google.com; s=arc-20160816; b=lyq5fLwjzm10JrUOWqzaSrai5rO4S//lGisFyg7EtuP6r7+UR9VjdgnnQo3KbGW80h CofdzO3/R7csW35gqTpduQ06QDNvvPdUjCeupV1zviiU2VfUUrCKcVavBUmnGL2IpU4k TrYVqA7YRsfX9uUSTLnSzKhkSVK0WGsCSeMzf2HEvEBLEXahgVwXgfyyg3HZPWRBy5qd H3b3x3E66Nz5cKzGVU7zgQftWwU5O7gLVCkWsPFnai6Ogwu28fUUu85tdaRS0Ljw4ekk D907TDRweamZAw4YHjtAkzwwS4nvSA4TeZFYCCk0VaiontNq3d84ehNkF26RWfu++N5a t8XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=S/y49anEKgqug7obHtTx9lvPdZL5qUSEFk1qvgto/L8=; b=QBSnk2qYHPO5xvcqtSMZfBBvGM4oKGFE4ZRIUEOd/62Hobm5kz0VGTdXdX+nztoern JJnBEmtSkSAwa6twssO1CqY20LPhiB/Hlqtmid4lZ3B75ReksssIIvKyWRspyFIvWkxo Q9VyO347NbdIMbBP4bOpl756g5xZnfU/pP3XkoolMzh8CBrMBd0Rn7CP+SSL+fwc0gXF KMllYe0Gjsn6wyAnXUj/1R/IG5QLTq/OSIOT37IQ9srnTdbBMYg6YCuYwe6QbN6Y4irT 5tinBXFBbj65HhmM3tEuuD/r7IvHlY1K7GbqQ0vBEfTiSMtp/ETFhvSxtHRYPsrICyNt 2Djg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g17si5751004ejo.93.2021.08.27.02.34.59; Fri, 27 Aug 2021 02:35:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244951AbhH0Jdr (ORCPT + 99 others); Fri, 27 Aug 2021 05:33:47 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:15262 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244863AbhH0JdT (ORCPT ); Fri, 27 Aug 2021 05:33:19 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Gwvcq615Yz8B0k; Fri, 27 Aug 2021 17:32:11 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 27 Aug 2021 17:32:17 +0800 Received: from localhost.localdomain (10.67.165.24) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 27 Aug 2021 17:32:16 +0800 From: Guangbin Huang To: , CC: , , , Subject: [PATCH net-next 5/8] net: hns3: remove redundant param to simplify code Date: Fri, 27 Aug 2021 17:28:21 +0800 Message-ID: <1630056504-31725-6-git-send-email-huangguangbin2@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1630056504-31725-1-git-send-email-huangguangbin2@huawei.com> References: <1630056504-31725-1-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggemi759-chm.china.huawei.com (10.1.198.145) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Li The param msg_q is redundant, copy &req->msg to hdev->arq.msg_q[hdev->arq.tail] directly makes code clean. So removes the redundant param msg_q. Signed-off-by: Peng Li Signed-off-by: Guangbin Huang --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c index d42e2715ab6c..46d06e1d04f9 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c @@ -161,7 +161,6 @@ void hclgevf_mbx_handler(struct hclgevf_dev *hdev) struct hclge_mbx_pf_to_vf_cmd *req; struct hclgevf_cmq_ring *crq; struct hclgevf_desc *desc; - u16 *msg_q; u16 flag; resp = &hdev->mbx_resp; @@ -243,8 +242,7 @@ void hclgevf_mbx_handler(struct hclgevf_dev *hdev) } /* tail the async message in arq */ - msg_q = hdev->arq.msg_q[hdev->arq.tail]; - memcpy(&msg_q[0], &req->msg, + memcpy(hdev->arq.msg_q[hdev->arq.tail], &req->msg, HCLGE_MBX_MAX_ARQ_MSG_SIZE * sizeof(u16)); hclge_mbx_tail_ptr_move_arq(hdev->arq); atomic_inc(&hdev->arq.count); -- 2.8.1