Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1235280pxb; Fri, 27 Aug 2021 04:36:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoQVEMbZ6e8sNBWplsxHtj5H4l67OVDTYPYmh1LmK15CVtZoMG73Vhou5xRttXtw0VuHKm X-Received: by 2002:a6b:fc1a:: with SMTP id r26mr7097705ioh.30.1630064184376; Fri, 27 Aug 2021 04:36:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630064184; cv=none; d=google.com; s=arc-20160816; b=W8TvjLOmkFnitk9L3eZAeD8c7CibCNS6fUtygvkqF3jX1MKRYdgbvv0nPb1qOr0NS4 xi5rVKju5h3umSm8oADF7N4fkEmywE6HCgmsSfUu7Br5NixBZYkgj3a6tkjNqYVfNxBm +GOKtMKo5wa28sK+YgBLQ5HdsgqWHxmoiTgA/UyL3uLtp8MHhh9ikd9paKHAlSEvyI+n g0XJ3Cb9sF+xDZfAXAqvnJBnCsPzcc8zyO2M+H+b5VuyIEva3peyTrZpe6aS522hFyvf +b8LIHdvVfNJOHtxBSgPAU5lX4ffe7mkQ3PQ2G4XwYOX1W1CzAkFBFL8o8WqDRf3ebml HAyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Le4te/e9isuWycyqZrcYYaONLdHszU7lSnZZrBkyn8g=; b=RHs67qGIkaTPoSYZhW2ZonXGGlh4oYqkbj+QH790uBByz+ScuQCecYz+U0SBzEsYyz 7NyLorUXi7/efkFKpHjbSSKCL/B3dEBrQ3lcyziWxi4X6y7Z+DBEF0gsYw31pDZuWOUC F8Qa9ChexybhtIYFezWv5gY4uDbPYbM6YwnXDyyzz7acabkh/+joPwLins0emyrHATMQ 5HSLmwfB1P1e6FU3t+bylcu7YEOFjPv8ekfi83ENCz1fIOJ29qIdSbqHiFE/WckhlP0Z 9v1cN9BkM54oK6xGPeJiZK1sMxofiKQNq2b9BE4HLh140SrizqSDK2YSIKU0fzBkSeUO 3EwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=n1wFxKxu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si7936906jat.85.2021.08.27.04.36.12; Fri, 27 Aug 2021 04:36:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=n1wFxKxu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245022AbhH0Len (ORCPT + 99 others); Fri, 27 Aug 2021 07:34:43 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:32410 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244978AbhH0Len (ORCPT ); Fri, 27 Aug 2021 07:34:43 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 17R81B0C012251; Fri, 27 Aug 2021 06:33:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=Le4te/e9isuWycyqZrcYYaONLdHszU7lSnZZrBkyn8g=; b=n1wFxKxu0eGhWzh5OCTtZ5sPPaC/Ts9+6IcMGCDGDxocd4KzZqIGqc9u0F8BRsyXgEP9 4GGTALt0xKBkmRzP4N6rdX8MgPTgHRNT7AxAGFtiD5Mt8RWnL/jnXOahQiSnedl2rwGK qgmrYcZtuz06BxVHXclV2FOTFHp1uqnknY5BD+Ayt/4ZkoUOjGPyG6Yr1V7O7n9QBSMQ dl1tB/GDJvI3d9C0BvSjb5DMIVNIMc+JKrvS25swmkdE+nkcmNdwfODwMTQvcWinBden lRJTZD3HWmuM8D1hUMnHvZIIPtWn65Wc9ZywS9GmfLKDAsxSV/M5cZqZhf8tvo49R/ry HA== Received: from ediex02.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 3apv5sg7fa-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 27 Aug 2021 06:33:08 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 27 Aug 2021 12:03:01 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2242.12 via Frontend Transport; Fri, 27 Aug 2021 12:03:01 +0100 Received: from vitaly-Inspiron-5415.ad.cirrus.com (unknown [198.90.238.186]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 5712846E; Fri, 27 Aug 2021 11:03:01 +0000 (UTC) From: Vitaly Rodionov To: Jaroslav Kysela , Takashi Iwai CC: , , , Stefan Binding Subject: [PATCH 2/2] ALSA: hda/cs8409: Initialize Codec only in init fixup. Date: Fri, 27 Aug 2021 12:02:52 +0100 Message-ID: <20210827110252.5361-2-vitalyr@opensource.cirrus.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210827110252.5361-1-vitalyr@opensource.cirrus.com> References: <20210827110252.5361-1-vitalyr@opensource.cirrus.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: 6eawfstDClbsJ7B6N6n2XcMhn2MQ4Sdv X-Proofpoint-GUID: 6eawfstDClbsJ7B6N6n2XcMhn2MQ4Sdv X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Binding It is not necessary to initialize the codec during both probe and inside the init fixup. Signed-off-by: Stefan Binding Signed-off-by: Vitaly Rodionov --- sound/pci/hda/patch_cs8409.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/pci/hda/patch_cs8409.c b/sound/pci/hda/patch_cs8409.c index 805441b7bf86..3c7ef55d016e 100644 --- a/sound/pci/hda/patch_cs8409.c +++ b/sound/pci/hda/patch_cs8409.c @@ -1024,7 +1024,6 @@ void cs8409_cs42l42_fixups(struct hda_codec *codec, const struct hda_fixup *fix, &cs42l42_adc_volume_mixer); /* Disable Unsolicited Response during boot */ cs8409_enable_ur(codec, 0); - cs8409_cs42l42_hw_init(codec); snd_hda_codec_set_name(codec, "CS8409/CS42L42"); break; case HDA_FIXUP_ACT_INIT: @@ -1229,7 +1228,6 @@ void dolphin_fixups(struct hda_codec *codec, const struct hda_fixup *fix, int ac kctrl->private_value = HDA_COMPOSE_AMP_VAL_OFS(DOLPHIN_HP_PIN_NID, 3, CS8409_CODEC1, HDA_OUTPUT, CS42L42_VOL_DAC) | HDA_AMP_VAL_MIN_MUTE; cs8409_enable_ur(codec, 0); - dolphin_hw_init(codec); snd_hda_codec_set_name(codec, "CS8409/CS42L42"); break; case HDA_FIXUP_ACT_INIT: -- 2.25.1