Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Jens Axboe <axboe@kernel.dk>
CC:     Bart Van Assche <bvanassche@acm.org>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        Paolo Valente <paolo.valente@linaro.org>,
        Niklas Cassel <Niklas.Cassel@wdc.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [RFC PATCH 0/2] improve io scheduler callback triggering
Thread-Topic: [RFC PATCH 0/2] improve io scheduler callback triggering
Thread-Index: AQHXm0DXb93kkZxy5kiaiP334AkFGA==
Date:   Fri, 27 Aug 2021 12:41:22 +0000
Message-ID: <20210827124100.98112-1-Niklas.Cassel@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?DnjEHjQsr4Bupm2phEVePqf+TpTmAri6GRdVYyGHD/xFKsifzjFBp9JvRb?=
 =?iso-8859-1?Q?O51lbrKTqyRBYsnZBNLGT8ZlZZ7EPlYPM6KZW5QsIDHl2QUXNVaQAi1GbY?=
 =?iso-8859-1?Q?p8nSDmVtT5Mkt8aeuhLaByBxdtPnBLNWjGJXd4uja7n2XO/tEjZzyWf9Nc?=
 =?iso-8859-1?Q?PvgeB9Aioe3w2iYpWssJFh8Pj25CXXRCz4G6ARc1oBkUY50lftFcOhDTCq?=
 =?iso-8859-1?Q?9qhvnVARG87lkZX5oE1D/hDNrDdJPjM5pUC1eqH0E4Dqlly1xDayk4nQcE?=
 =?iso-8859-1?Q?xEdL2haVEYY+v8ZLidM9woLnznbmDi5WCCnFY86heUSZTG9q11jz9THdkB?=
 =?iso-8859-1?Q?OJ8v5l+18FeDD0zaI12VCj2HCeeuWlmnLjE0DJKxod4brYHeOHS10MY955?=
 =?iso-8859-1?Q?PaiPwfkwRU5GQ+6xWzdtNcF8nHLxgsbufwXqewHd2HEsfnu6hGoT6dpC1x?=
 =?iso-8859-1?Q?mMcnwh2m/Sdu2A5Pb2HpAIgS+stK36j+2XD4PafZWvl4mARlahkXTvuewy?=
 =?iso-8859-1?Q?cn7KMHjKQouP01ZMxVxSTBXudupxs7doLOWVBFec7tGmbcIud7RdMMgcqB?=
 =?iso-8859-1?Q?hVf+INns4uD0WfdO1KQQa1f7cmLIsMS6tyXKCW+zsWJ2zwV+eXgxA+eyGe?=
 =?iso-8859-1?Q?j44mYwSKyBicvmYWLSWaw40fIKNglnQWECuJnUtYfVWcCJMqzGwB16mn7l?=
 =?iso-8859-1?Q?o+tRTN4ryskcRMZbjj8K0KNIRa60GBmkzFqIan5t+HKzrcNtwRVoX+TMe5?=
 =?iso-8859-1?Q?2+9izQ2nW3q4fiNmIwuZ0DcKFVQ5oKU50gUWHpMNPtj0kAqyXm2sbi1Y41?=
 =?iso-8859-1?Q?KaVyatFn1KCX9DC/1pd0zAOSOG3gc4ig+SKXQK8ZsBd2BSXUIbC7qScTvw?=
 =?iso-8859-1?Q?GBpsfRlRw39dMt+2GWzi3vczyQOnUuj9zPUV5s3dRAoP0YiNVhvxvjw3xw?=
 =?iso-8859-1?Q?FGVWFglJfnePxI5gxd8cJ+782ySBcEv59SFfNVHrxOTzcEhmehP1bsO4mj?=
 =?iso-8859-1?Q?NVX7kQEFiqBnYiio+RzQ+Aaafu3MttRULUjFJqJ7tNBN7OviXB+FRd8a0g?=
 =?iso-8859-1?Q?j8ljzPT7ZX+t68O+8wQ0BxbkgEN1ulNp9EZSk6N4XCydKSpKZV8cBlvK2Y?=
 =?iso-8859-1?Q?5V1eKMorxTuv6wBkOpt+6x0RxFezTxTLPe1Lm/fCljJbCbuUj3S5rk4K04?=
 =?iso-8859-1?Q?mqzo/F7MSVAbjJwhj1szrZfbxRPop7zvQV4Eyv+XOIRUZwWF3qxf6OY/jV?=
 =?iso-8859-1?Q?sPs7J7hwHLwaK+oaWtw95xJ31Zhg8YDz/LcqE5Uqt6aHnaLxn1vP9FqM5w?=
 =?iso-8859-1?Q?SXt53U+V5k7ziSwbQA3SYZCn1l4S3yo0+dPES6hI+JTENkp8uvu5Tn5XH9?=
 =?iso-8859-1?Q?Hybu/Ien6MY4GFM5iXEG68Lov/JOef5A=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7158.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c613b99-69ab-4f41-5467-08d96957f9fe
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2021 12:41:22.5019
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7BgTyUgxzVUyUb22iX96f6GvlfflpV6oVDCb5jyWfDZ+N9ZCZNhb71rN/70R+e970KkNm3bsUWmRZBTVMWanKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7702
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Niklas Cassel <niklas.cassel@wdc.com>

Recently, there were some extra "dummy" data added into mq-deadline
rq->elv.priv, that was there for the solve purpose of working around
shortcomings in blk-mq (which called the scheduler callbacks even
for requests that bypassed the scheduler).

Fix blk-mq to behave in a more sane way with regards to scheduler
callback triggering, and remove the now unneeded rq->elv.priv magic.

BFQ should be able to perform a similar cleanup, and should be able
to drop this comment from the code:
https://github.com/torvalds/linux/blob/master/block/bfq-iosched.c#L6456-L64=
62

Considering that I'm quite unfamiliar with the BFQ code, I'd rather
someone who is a bit more familiar with BFQ performs that cleanup.


Kind regards,
Niklas

Niklas Cassel (2):
  blk-mq: don't call callbacks for requests that bypassed the scheduler
  Revert "mq-deadline: Fix request accounting"

 block/blk-mq-sched.c   | 20 ++++++++++++++++++++
 block/blk-mq.c         | 13 -------------
 block/mq-deadline.c    | 16 +++++-----------
 include/linux/blkdev.h |  3 ++-
 4 files changed, 27 insertions(+), 25 deletions(-)

--=20
2.31.1