Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1319805pxb; Fri, 27 Aug 2021 06:24:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYNXS5+ul6sy5c/0RHKAZCpeTXBRZgv+nX/iITFrzkWE6U1ZMikycjPLghCw0n5qQPLxrc X-Received: by 2002:a17:906:b745:: with SMTP id fx5mr10207585ejb.515.1630070684619; Fri, 27 Aug 2021 06:24:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630070684; cv=none; d=google.com; s=arc-20160816; b=HcJ1Kg1p/JCqfkH7NI6HY2UcyGon4/rP7ugX1IR12f3HWQoMTT9be02iP3lwNm6Mcr vZ1FxzbKb3RGyo41wUdBtiErepviZlXkbjx14GMc7DoW1ZfSyMa1KOtqRWuRkIM/EDo7 5CI2Uu7jNgEuXiUPUqftc5GM4R4xClnwYsORzIDdBQJ5LgSYyrFh+nbv+m5WQsB8l2mV r4y2bbk65LoC5RX4rWAkLXLkP7lS1vBHJuIvaImds11XlRpRq7kjT7p+eMFJtX6uH6kx Nb4EDZ+nKpfFb8NtyC8Ywo0MLzIB1SkOx6BJExA+JBsKjUin/mO2ne7oFg6Av6tZUuBj QpKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=sx7pQgEx87oMQA/dv8sHcfHdav4X18SLvmQSOMhPjPE=; b=nphfyjF4WDmK2RbjgBie6t22EONYFA5Wupi37pLGJSTH4ysQOzs7hQDs+n50v+gNtx lvnFpAbi2UON3lYqg/UQG5HRJo+eldFC1nEX4vwsh9pB4I5NiP/52sQiUUZiFWyHA9Oo ai9JXPPkrhZnnu5MbI+JUTSCiizwjWtAt8zSR+MJ61Vm9tZ+9NxN5K/cCurq4Ae09Ecq t7iiMfeKxsbKYc7S6vKft5nSWKDmw+Num7Z5LNgKEHi3p0bA/xeIxvovLBMctjBNdZIP G81FK6CLSFl7XvM3RSIBoFfEWxgLa8aN31NOAkOqyPMacz8TZ03D/Iah6BjdeqCCWP6f iCig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u5si6225210edb.324.2021.08.27.06.24.19; Fri, 27 Aug 2021 06:24:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245322AbhH0NXZ (ORCPT + 99 others); Fri, 27 Aug 2021 09:23:25 -0400 Received: from ozlabs.org ([203.11.71.1]:35665 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245421AbhH0NXB (ORCPT ); Fri, 27 Aug 2021 09:23:01 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Gx0kC2ppdz9t0T; Fri, 27 Aug 2021 23:22:11 +1000 (AEST) From: Michael Ellerman To: Michael Ellerman , Christophe Leroy , Paul Mackerras , Benjamin Herrenschmidt Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org In-Reply-To: <373ec500f386374bc5735007df3d3869eac47be1.1624618701.git.christophe.leroy@csgroup.eu> References: <373ec500f386374bc5735007df3d3869eac47be1.1624618701.git.christophe.leroy@csgroup.eu> Subject: Re: [PATCH] powerpc/syscalls: Simplify do_mmap2() Message-Id: <163007016188.52768.15412686650316297072.b4-ty@ellerman.id.au> Date: Fri, 27 Aug 2021 23:16:01 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Jun 2021 10:58:33 +0000 (UTC), Christophe Leroy wrote: > When shift is nul, operations remain valid so no test needed. > > And 'ret' is unnecessary. > > And use IS_ALIGNED() to check alignment, that's more clear. > > > [...] Applied to powerpc/next. [1/1] powerpc/syscalls: Simplify do_mmap2() https://git.kernel.org/powerpc/c/316389e904f968d24d44cd96a6d171ee1ef269cf cheers