Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1324740pxb; Fri, 27 Aug 2021 06:31:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAYvpjjJLnofyS5pgXE54uNX8QSQ0eLgI4/2ZMwHUDWSEXZ7hb7MpFpD3BwHT9RmGCJ1C6 X-Received: by 2002:a05:6402:40cf:: with SMTP id z15mr667739edb.70.1630071062753; Fri, 27 Aug 2021 06:31:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630071062; cv=none; d=google.com; s=arc-20160816; b=PSNNDkYHmf5sOvg7iU3fhpSAW25kTSNNp8GTTVhS6B+337loe1yBmq5mQG+DMJNCqv W89aOoy+eLipaSWDGeUzZO6MiUF0nl9lmd4IkBfGjHoX83kOazEELLaYX9XeHmutOBXe YY3fgiccSD6ZHZXVS1vW0tUowK8EPsE+uiiX5YhbjtxfxLJTcx6KVpw5C52n9DFWjnCD FKuFS2M4HpbO4d7xhWzdroSQPy+zJlHdfuDptbxuy4gFEixWH5WEwpxu4Su73wNL4clK HdkU28jnIyDizuK8X7ctOSWZbL983CLLd+EBRdwJfRdvLmbbKBiEsUnGZAKPlPvfv3yp a8AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=7+l2OUe326Py0LuL0Zx97pEONSj51Fd9KoHdQXMPwMg=; b=ZlyN0vrsxYuOPf4QraQk5B+v1+I9qlrlLCJXjT7G64eDose6AnjKeoGS60LcdhX2La uyyk5xOKHQuWw3TWz8AeL4k2XliZZi6JvL8SSfCEnc7gnO3pMDX1gzbUIliR3AAFdIf7 Nokfdj8z1RNdU6GJ2q/k175lmC0gZkYPomgD6zgpD1q4xBBRZKQlIMnM6q1RjLP0s+au 2ACpJhgJW4BI0X8VCFuoSkvNRqFXrTVxRpkWpXQ26TPFuSDaeBwpdFXRoWEUNaHXtmQz fpuO96yeQjVUpsblNolb1VeWPBkLRj+G0dgy67YdsrKl8ij2/pg4SWghwb4RCu14LUO6 /ZMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hp37si6357012ejc.171.2021.08.27.06.30.34; Fri, 27 Aug 2021 06:31:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245192AbhH0N1b (ORCPT + 99 others); Fri, 27 Aug 2021 09:27:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231964AbhH0N1b (ORCPT ); Fri, 27 Aug 2021 09:27:31 -0400 Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EF90C061757 for ; Fri, 27 Aug 2021 06:26:42 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Gx0qM6Gz8z9sRf; Fri, 27 Aug 2021 23:26:39 +1000 (AEST) From: Michael Ellerman To: Benjamin Herrenschmidt , Paul Mackerras , Christophe Leroy , fthain@linux-m68k.org, userm57@yahoo.com, Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org In-Reply-To: <4856f5574906e2aec0522be17bf3848a22b2cd0b.1629269345.git.christophe.leroy@csgroup.eu> References: <4856f5574906e2aec0522be17bf3848a22b2cd0b.1629269345.git.christophe.leroy@csgroup.eu> Subject: Re: [PATCH v2] powerpc/32s: Fix random crashes by adding isync() after locking/unlocking KUEP Message-Id: <163007070021.56462.16976826768640062743.b4-ty@ellerman.id.au> Date: Fri, 27 Aug 2021 23:25:00 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Aug 2021 06:49:29 +0000 (UTC), Christophe Leroy wrote: > Commit b5efec00b671 ("powerpc/32s: Move KUEP locking/unlocking in C") > removed the 'isync' instruction after adding/removing NX bit in user > segments. The reasoning behind this change was that when setting the > NX bit we don't mind it taking effect with delay as the kernel never > executes text from userspace, and when clearing the NX bit this is > to return to userspace and then the 'rfi' should synchronise the > context. > > [...] Applied to powerpc/fixes. [1/1] powerpc/32s: Fix random crashes by adding isync() after locking/unlocking KUEP https://git.kernel.org/powerpc/c/ef486bf448a057a6e2d50e40ae879f7add6585da cheers