Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   John Garry <john.garry@huawei.com>
Subject: Re: arm scsi drivers
To:     <linux@armlinux.org.uk>
CC:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hannes Reinecke <hare@suse.com>,
        "Christoph Hellwig" <hch@lst.de>,
        Bart Van Assche <bvanassche@acm.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
References: <5a72842f-99db-8787-120b-6d85e7884e2d@huawei.com>
Message-ID: <9552a506-e53a-3fd3-b38e-3cec81e713a6@huawei.com>
Date:   Fri, 27 Aug 2021 15:55:05 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <5a72842f-99db-8787-120b-6d85e7884e2d@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Russell,

Have you had a chance to consider the below?

Thanks


> 
> Recently we tried to remove scsi_cmnd.tags struct member [0].
> 
> However it now shows that some of the arm SCSI drivers continue to use 
> this [1]. I think any other driver usage of this member had been found 
> and removed.
> 
> The impression is that the usage of scsi_cmnd.tag in those drivers is 
> quite dubious.
> 
> Now checking [2], it appears that you may have had some patches for 
> these drivers locally.
> 
> So is that the case? Is this HW still used with bleeding edge kernels? 
> If so, can we fix up this tag management?
> 
> [0] 
> https://lore.kernel.org/linux-scsi/6c83bd7f-9fd2-1b43-627f-615467fa55d4@huawei.com/T/#mb47909f38f35837686734369600051b278d124af 
> 
> 
> [1] 
> https://lore.kernel.org/linux-scsi/6c83bd7f-9fd2-1b43-627f-615467fa55d4@huawei.com/T/#md5d786e5753083b2f3e8e761b1c69809f82c7485 
> 
> 
> [2] 
> https://lore.kernel.org/lkml/20210109174357.GB1551@shell.armlinux.org.uk/
> 
> Thanks,
> John