Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210825185747.1627497-1-daeho43@gmail.com> <1f1e6d38-6bd1-17ea-b8ca-a45d1244728f@kernel.org>
In-Reply-To: <1f1e6d38-6bd1-17ea-b8ca-a45d1244728f@kernel.org>
From:   Daeho Jeong <daeho43@gmail.com>
Date:   Fri, 27 Aug 2021 08:22:25 -0700
Message-ID: <CACOAw_yhgo1_wrejKskSm=Rsw27ogx=TS_A=z=-NGLcecA-gYA@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: introduce fragment allocation mode
 mount option
To:     Chao Yu <chao@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
        Daeho Jeong <daehojeong@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> I'd like to add a fixed chunk/hole fragmentation mode in addition, then
> userspace can control the fragmented chunk/hole with fixed size.
>
> How do you think of renaming "fragment:block" to "fragment:rand_block", and
> then I can add "fragment:fixed_block" option and its logic in addition?
>

The reason I added the randomness on these values is the segment
selection in SSR mode.
If all the segments have the same free block counts, f2fs will
allocate a new segment sequentially in SSR.
This was what I didn't want. Plus, in the real world, the size of hole
and chunk will be different in different segments.

But, if you think we need this "fragment:fixed_block" mode, I am happy
to have it. :)

> Do we need to consider multiple thread scenario? in such case,
> .fragment_remained_chunk may update randomly.
>
> In addition, multiple log headers share one .fragment_remained_chunk,
> it may cause unexpected result, it means there may be continuous holes
> or chunks in locality due to swithing between different log headers.
>
> Thanks,
>

Oh, I overlooked that point. I am going to add the variable for each
segment as you said before.

Thanks,