Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: arm scsi drivers
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        John Garry <john.garry@huawei.com>
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hannes Reinecke <hare@suse.com>,
        Christoph Hellwig <hch@lst.de>,
        Bart Van Assche <bvanassche@acm.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
References: <5a72842f-99db-8787-120b-6d85e7884e2d@huawei.com>
 <9552a506-e53a-3fd3-b38e-3cec81e713a6@huawei.com>
 <20210827150938.GU22278@shell.armlinux.org.uk>
From:   Hannes Reinecke <hare@suse.de>
Message-ID: <087d1fa0-8796-5b97-36fc-379498f53380@suse.de>
Date:   Fri, 27 Aug 2021 17:23:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210827150938.GU22278@shell.armlinux.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 8/27/21 5:09 PM, Russell King (Oracle) wrote:
> I haven't, sorry.
> 
> I have run 5.x kernels on the hardware, and do have a set of patches
> kicking around for the SCSI drivers that do some cleanups. It looks
> like the fixup is pretty simple from the links you've sent - using
> scsi_cmd_to_rq() to get the tag.
> 
> That said, I think I may only had one SCSI drive that came anywhere
> close to supported tagged queuing, so I never put much effort into
> tagged command support. Both acornscsi and fas216 have it disabled
> for this reason, so it's probably easier just to rip the tag code
> out of these drivers.
> 
That's what I figured, too.
And that's what my patches do, killing the tag support from arm drivers 
which had them disabled since the dawn of git history.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer