Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
CC:     "kbuild@lists.01.org" <kbuild@lists.01.org>,
        "lkp@intel.com" <lkp@intel.com>,
        "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [kbuild] drivers/net/ethernet/mscc/ocelot_vsc7514.c:554
 ocelot_xtr_irq_handler() error: uninitialized symbol 'err'.
Thread-Topic: [kbuild] drivers/net/ethernet/mscc/ocelot_vsc7514.c:554
 ocelot_xtr_irq_handler() error: uninitialized symbol 'err'.
Thread-Index: AQHXmxIxxp8Lq1J80kCAsxoAermcaquHf46A
Date:   Fri, 27 Aug 2021 15:47:34 +0000
Message-ID: <20210827154733.ecd4viobsbfe3k7a@skbuf>
References: <202108271503.UUJHV4l5-lkp@intel.com>
In-Reply-To: <202108271503.UUJHV4l5-lkp@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YOIiTunP2FAg28f1NJnYIgOUcINPpi/1QIg80LnT+IcQXAvXWOkGlKmw1JOb?=
 =?us-ascii?Q?KVWkHDazXRrv35Tnj5f44d9Jufmcy/ClVRWBPgad09lLNnUPXOCqVBY8QQS5?=
 =?us-ascii?Q?f9JsVyzJKR7vT/UlItDbow9fa702mowHghbtVUQ6iyLmtaecZYXl2gfjXBEb?=
 =?us-ascii?Q?eECExVO9VRq6YtbTzOtXNvH95FzN4kriotfwkVB7EWqehCE82RrzXPu590MG?=
 =?us-ascii?Q?fFnHqje4KnBBjBtBMBlyEIv258YoYWcmOVSisMCCvwiw2C/JLLoR6Gp6VQz7?=
 =?us-ascii?Q?t1Z8vkafzGK2H5R5xejafyZMfeNCBGCYzGWi8c78kMBwEGArUiiGDHMQVADm?=
 =?us-ascii?Q?ODDi0qW2w3/t39hf+zLXm96XVZyTDNtB8jsJDjAXe1NmDyd3zsfqxdtinOpN?=
 =?us-ascii?Q?rwZy7t+sfHwarERvKzo/fhJQwbLMS1D8IIclHx8A+9qXNK7drJNvhngbvBbi?=
 =?us-ascii?Q?IemF99RrTUN4kmkMe4AyLvsuyDq7I0u44ipChdDr60hI/Lz/9vLvlQosWETl?=
 =?us-ascii?Q?tPz/zT89VWu60g+RX6nxR6HvEGEpX1n23yoPg6MEq70V4ZZ3VcrJvW5s42Wz?=
 =?us-ascii?Q?vCrWZsQFCOrLlUjjkMJPzSSO67IcBJsDgSTYnkTfkkNFYN1VDTwpIMfubFFA?=
 =?us-ascii?Q?XOS/d9IOtvd8531iv08HD/vaF8E6o70qY23+9Nd2/Yb/5q/PhtDhgITs2kaL?=
 =?us-ascii?Q?+vBXvYLfW9ERznXwiTZLoxcZnUGQqWZR8hpCJ8ZEh4gG0Q3sBTdMT8GS/hP1?=
 =?us-ascii?Q?p9vIQolsuHCZGPr1ZNf04vhrLIGeg6QIPqUt6bKTw3yelZfu7xBMo6/8Eopy?=
 =?us-ascii?Q?/XwVSlVpQbxePRbMxaW+jfO/SDvdDEvI/KINmZQNHjPF3jRl6W9tmJ4SOe7z?=
 =?us-ascii?Q?viA5lcFGg5tYIWI+tekYRTOa0ujPwAN8tMPtsac2tsEkC3nkapY2DMdbVXEq?=
 =?us-ascii?Q?zvdP1hhFLQfspofwJ8iF/57Q6MtwOC5lGmTvEBh5PprJ716HsksGTatufiCv?=
 =?us-ascii?Q?RLq/Q3u3t0t+tYlZDAEcvPbufYczuX2LKzPSgjvPmKWYnU77Dmx7ido1LlwM?=
 =?us-ascii?Q?XNZ2Z8ax/9bE5kAWSvl1HHeAYLAUWkRvrCXZoN5dHsn8Z/cADf/arMqzGOGf?=
 =?us-ascii?Q?+nT1BOPQ9qKQ70xvui4k/V45r3xkfcrXxi8JbuVTyDsID1e+O1NMfSfPT9LH?=
 =?us-ascii?Q?gP1sT96c4ojeILMzE6U68rg1I3yJNgzRgS0S9+WpWoha1fcLdAylwOoB/JR1?=
 =?us-ascii?Q?Ox40UBFFUKAYBBdueqUZTbFJqnkgOG0OGnagn0MmejmimEAi2gKbNV3xP/ux?=
 =?us-ascii?Q?MKGuml43vI8ruNPu8S3IaC/S?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <687559FFC5A0EA42B8A0C7191A9F204D@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45e7968d-90dd-4848-0569-08d96971fd02
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2021 15:47:34.5555
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wu81rbpS0tuctwj3vBtSBqhqal7VwtnC1Fx9IlxcTt9a99uRZLgBzOVUnTurlXAORegm4Zc/Q5yyby8IsuhQiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2862
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 27, 2021 at 10:06:42AM +0300, Dan Carpenter wrote:
> static irqreturn_t ocelot_xtr_irq_handler(int irq, void *arg)
> {
> 	struct ocelot *ocelot =3D arg;
> 	int grp =3D 0, err;
>
> 	while (ocelot_read(ocelot, QS_XTR_DATA_PRESENT) & BIT(grp)) {
>
> Can this condition be false on the first iteration through the loop?

Functionally speaking, no, but if it helps anyone to initialize "err"
with 0, I guess we could...
>
> 		struct sk_buff *skb;
>
> 		err =3D ocelot_xtr_poll_frame(ocelot, grp, &skb);
> 		if (err)
> 			goto out;
>
> 		skb->dev->stats.rx_bytes +=3D skb->len;
> 		skb->dev->stats.rx_packets++;
>
> 		if (!skb_defer_rx_timestamp(skb))
> 			netif_rx(skb);
> 	}
>
> out:
> 	if (err < 0)
> 		while (ocelot_read(ocelot, QS_XTR_DATA_PRESENT) & BIT(grp))
> 			ocelot_read_rix(ocelot, QS_XTR_RD, grp);
>
> 	return IRQ_HANDLED;
> }