Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     Mark Brown <broonie@kernel.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Lee Jones <lee.jones@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>, Marc Zyngier <maz@kernel.org>,
        "Z.Q. Hou" <zhiqiang.hou@nxp.com>, Biwen Li <biwen.li@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] regmap: teach regmap to use raw spinlocks if
 requested in the config
Thread-Topic: [PATCH 1/2] regmap: teach regmap to use raw spinlocks if
 requested in the config
Thread-Index: AQHXmfLp4ns/CR9SwkOJBzcXz4/yJ6uGaLyAgAEgBoA=
Date:   Fri, 27 Aug 2021 16:12:28 +0000
Message-ID: <20210827161227.4pnaglgctikobpf6@skbuf>
References: <20210825205041.927788-1-vladimir.oltean@nxp.com>
 <20210825205041.927788-2-vladimir.oltean@nxp.com> <875yvr3j5c.ffs@tglx>
In-Reply-To: <875yvr3j5c.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nio5ypZHCGu1ngg0olDZrcobYec1nvAUEPyJ0uHsaCS4gTxRnB65sY7lqgDY?=
 =?us-ascii?Q?KHETz/eImOLhnlJqGJEDFqC63NlRo+YrWh9929tOv6/9O5E0R4LCDv2W7ItS?=
 =?us-ascii?Q?vsBKpaXdYqNV6wFUIPYOCiwkwVk+DwgayU0InjUIaWNHLJxXujbofr4EzOJM?=
 =?us-ascii?Q?+0sYmXjHgrsJQVOkyYFONAPJuZD5fBtLQaoCFSV6IV5xMxcvBGWlaCJNwDnk?=
 =?us-ascii?Q?WAdY264zi15Z0lXy2lPwMLvuN2O91G4u0IlB5CfphLlMlS2kKoQe0rzB9bQO?=
 =?us-ascii?Q?7kZu4uDP6LEE2J2wWGrGFQDMcRb1fIpr17lKRSIwHXFMMWlg5bSb9pga2gh6?=
 =?us-ascii?Q?9l8Ktyt7kG89VDgmgH6Fd9yaC2aF9bpqAADV3OL/504jDNVi064flbs5ngNv?=
 =?us-ascii?Q?8ME3q4zl9GOv5zbDLSFTkr2EQI15GqXJmBmyfz7uXtTOj9FHRpfQ2zQP9K++?=
 =?us-ascii?Q?x5pOwDli2VaOJvbe2DHHqK5uoHqz8Sm+lxiPTfP2HIFtTm358lbt+lZNyEUD?=
 =?us-ascii?Q?mucpY7azk4Y7Kunlcn5SK0F24NDduu6aPfkCTxXTC2OFMDFh0iliuoKq/4pG?=
 =?us-ascii?Q?00L3kBa78liitqiWOLXOfWIM+7cCr+HYJCd2vIUPqEOg5QlPyc4qY1shK62v?=
 =?us-ascii?Q?8+IRuKmYbGXWMH8Bi4pDpl6d+YKCJwm7H7BRnFqtWg7MDQJzsuJaKFxuASVi?=
 =?us-ascii?Q?lCFNXoZuzBAYDV9Ynxnr0KyG0iPcWm/UUF2MmR7budwxFQ0hpRHkFf5iHUQg?=
 =?us-ascii?Q?TcPdzevd7N1eVmWiosEu+a6bAZHC4j8Gs8a6WSeTJOEpKTCQEY69NHNz9Iyu?=
 =?us-ascii?Q?RjLYHc92zux4gJ2Cza2n4ilXr26oDM8iD4HkwydQ4MUXh0U+GxcKeHOmgsn0?=
 =?us-ascii?Q?ZFN89No3RvGPJsna+7gvCA9XJwJlDu0TrbsEMLMkLWOdalwkMiDQRdHuZKbH?=
 =?us-ascii?Q?wJ0XGFqe9RLOWyYPyKuaMRsiANhM5VBCjj/GwyzkSRG5Q5LM9bWNzryP2mVU?=
 =?us-ascii?Q?jC4VPjA8BToVCJeAUxBNIJKpTQSBB/41YukmvoNjif8VptKnr4qDOF4pZHA6?=
 =?us-ascii?Q?pvaJd0OwY3W/4+OyiYjJ9j4c+LWSBnpQ2D2RsbzeTlkhra2k+FIWiMC5XPm0?=
 =?us-ascii?Q?HY1vaP+cX7ehDynSyAv7iNasu+eM/sBi/cIn/FIQPXyZwY1U1LEZ1ifJkM73?=
 =?us-ascii?Q?fiMZSelOm9ycHRog1UefQcz3FJJlpt4n93PFZo501QoNZGjiLh8m9pPbhsh5?=
 =?us-ascii?Q?Nsnk1v5mBZzNFl6PllzOZ7cFlQvXjLE8XHewq/FlJAa0BSJk6UN0KZLsn/yb?=
 =?us-ascii?Q?eS8Txgu4vExZKLoBoTe0PZOK?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <41320510ACF9E04C9E2AE7CBCE43A353@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 279d4c55-b0d8-4db0-0353-08d96975773f
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2021 16:12:28.1025
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TpRdVcnwg64P6bVXMdtPYeeE0mxV2CTtpAXhjjEMxyU0xHLAe4qsWTAiSZdIcertQNaaKv1DGM+AyW1RoEc//g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6512
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 27, 2021 at 01:01:35AM +0200, Thomas Gleixner wrote:
> On Wed, Aug 25 2021 at 23:50, Vladimir Oltean wrote:
> > It seems reasonable for regmap to have an option use a raw spinlock too=
,
> > so add that in the config such that drivers can request it.
>
> What's reasonable about that?
>
> What exactly prevents the regmap locking to use a raw spinlock
> unconditionally?
>
> Even for the case where the regmap is not dealing with irq chips it does
> not make any sense to protect low level operations on shared register
> with a regular spinlock. I might be missing something though...

Mark, any comments?

Generally it is said that misusing raw spinlocks has detrimential
performance upon the real-time aspects of the system, and I don't really
have a good feeling for what constitutes misuse vs what is truly justified
(in fact I did start the thread with "apologies for my novice level of
understanding").

On the other hand, while it does seem a bit too much overhead for
sequences of MMIO reads/writes to be able to be preempted, it doesn't
sound like it would break something either, so...

But I will say that I've tested that and it would solve both my problems
(the stack trace with ls-extirq and the fact that I would like to avoid
reworking the ls-extirq driver too much), as well as problems I never
knew I had: it turns out, armada_37xx_irq_set_type() uses regmap too
(and a sleepable spin lock too - irq_lock). The latter would still have
to be manually patched out.=