Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC
To:     "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>
Cc:     "philip.li@intel.com" <philip.li@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20210826015847.7416-1-lizhijian@cn.fujitsu.com>
 <20210826015847.7416-2-lizhijian@cn.fujitsu.com>
 <239339d5-5626-ea04-97db-7dc070a48636@linuxfoundation.org>
 <69835666-1710-5103-fb06-2636a3a3c5bb@fujitsu.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <2c141f7e-bec8-49ad-2d2b-d238a372b0e6@linuxfoundation.org>
Date:   Fri, 27 Aug 2021 11:00:43 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <69835666-1710-5103-fb06-2636a3a3c5bb@fujitsu.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/26/21 7:35 PM, lizhijian@fujitsu.com wrote:
> 
> 
> On 27/08/2021 05:10, Shuah Khan wrote:
>> On 8/25/21 7:58 PM, Li Zhijian wrote:
>>> SYNC was removed since aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")
>>> LKP/0Day will check if all configs listing under selftests are able to be enabled properly.
>>>
>>
>> Can you please state what you arr fxing and also keep the sentences
>> 75 chars or less.
>>
>> Where is LKP warning?
> https://01.org/lkp
> LKP(aka. 0Day) often reports issue related to the *recent* kernel commits/WIP patches publicly.
> As the LKP keeping improvement, it will cover more aspects in the kernel so that more issues will be detected.
> 
> So in this case, which is related to too old kernel, it just reported it internally.
> 
> 
>> Include the warning and explain why this
>> change is necessary.
> - it's not reasonable to keep the deprecated configs, right ?
> 
> - In my understanding, configs under kselftests are recommended by corresponding tests.
> So if some configs are missing, it will impact the testing results
> 
> Do you mean the commit log should include above 2 reasons ?
> 

Correct. I am asking the commit log to include these details.

thanks,
-- Shuah