Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To:     Kari Argillander <kari.argillander@gmail.com>,
        Christoph Hellwig <hch@lst.de>
CC:     "ntfs3@lists.linux.dev" <ntfs3@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        =?iso-8859-1?Q?Pali_Roh=E1r?= <pali@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Christian Brauner <christian.brauner@ubuntu.com>
Subject: RE: [PATCH v2 3/6] fs/ntfs3: Use new api for mounting
Thread-Topic: [PATCH v2 3/6] fs/ntfs3: Use new api for mounting
Thread-Index: AQHXlJD4Aw/BzjELzkaNCIdXoLLU5auCIX8AgAAFSYCABZaw8A==
Date:   Fri, 27 Aug 2021 18:44:07 +0000
Message-ID: <9dcbd4fb0dcf434f9241d2ef13763428@paragon-software.com>
References: <20210819002633.689831-1-kari.argillander@gmail.com>
 <20210819002633.689831-4-kari.argillander@gmail.com>
 <20210824080302.GC26733@lst.de>
 <20210824082157.umppqksjl2vvyd53@kari-VirtualBox>
In-Reply-To: <20210824082157.umppqksjl2vvyd53@kari-VirtualBox>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

> From: Kari Argillander <kari.argillander@gmail.com>
> Sent: Tuesday, August 24, 2021 11:22 AM
> To: Christoph Hellwig <hch@lst.de>
> Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>; ntfs3@=
lists.linux.dev; linux-kernel@vger.kernel.org; linux-
> fsdevel@vger.kernel.org; Pali Roh=E1r <pali@kernel.org>; Matthew Wilcox <=
willy@infradead.org>; Christian Brauner
> <christian.brauner@ubuntu.com>
> Subject: Re: [PATCH v2 3/6] fs/ntfs3: Use new api for mounting
>=20
> On Tue, Aug 24, 2021 at 10:03:02AM +0200, Christoph Hellwig wrote:
> > > +	/*
> > > +	 * TODO: We should probably check some mount options does
> > > +	 * they all work after remount. Example can we really change
> > > +	 * nls. Remove this comment when all testing is done or
> > > +	 * even better xfstest is made for it.
> > > +	 */
> >
> > Instead of the TODO I would suggest a prep patch to drop changing of
> > any options in remount before this one and then only add them back
> > as needed and tested.
>=20
> This could be good option. I have actually tested nls and it will be
> problem so we definitely drop that. I will wait what Konstantin has
> to say about other.
>=20
> > The mechanics of the conversion look good to me.
>=20
> I have made quite few changes to make this series better and will
> send v3 in the near future.
>=20
> Main change is that we won't allocate sbi when remount. We can
> allocate just options. Also won't let nls/iocharset change.

Hi Kari, looking forward to have v3 series to pick up!

Best regards.