Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1582476pxb; Fri, 27 Aug 2021 12:10:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuaOyrn//rYnzMmnYeWgysCXdli77CqyFk1Z9nSB7J7MC8xYk+f2dX4HNCGO67cxYXyXAl X-Received: by 2002:a02:c7d2:: with SMTP id s18mr5521711jao.22.1630091438941; Fri, 27 Aug 2021 12:10:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630091438; cv=none; d=google.com; s=arc-20160816; b=OCMyxoj8Hocrn3cUUN5G6NMgtRz+VKLyrCKXFQp71qEGnvnonmwEwfjS5fVEJu+Yk9 23yhlOltC0aXtLrPBeE8lXUPOUgYxv2XNHlrkwp7YhKbysROkw9RqoiTER1fihLcWqCU pFjJ9Jsh/y9eSAHBGXTVULR7eBKQlCYkgBEGN+8wXDwm2It5dP44+sjfgTLqF59P6VNE hb15Id/+7OxEjkv9t1e7G4YDNd9uPor0CSy3do+a+iX4CdTD3uxA6sYJGH2090Ae714l knklQ1SoMuTGLJeYLYS2RltjlE+44FdwN5RbQEoiYyQA/oGkmC+mOOrIhQlXyUIBF5am vpBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=VJ+m3uiw8o2amI6646G+MP6wQ/i5bsPd/8ytgE69Rks=; b=Wl32voU3ueZ/QQUFe3EJvpr7F+S5871tLy61kzI+w+t/Wm1EP0H8eduBkxVBt7Z5nu kTAq4ldRajeVdAwpMndQGP7PeJNlQqqCsEuwxG3Nwq1w0eBPvjnyvW8uqmF5ZcNacfsJ 8c+lZSaQ0NMgG3vJYR+H8YF8B7UumBYOaKM0xq+VNI+y+1XmwYEZtFVfEx0msNDi9LlF ePYZY9JxC111yMpV1XrI4Z0r4LiheYFw8qxd6YSCC/aSun00AEs6+oH9NeN/NqF02FJ0 KlhqPpF0T1xbLsz84l6dQiBmqYWLdjiw5lV0uxFY2KUrOO66l400QFLU8Fl73Wi1xXDs yXpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c11si6290614jaa.116.2021.08.27.12.10.26; Fri, 27 Aug 2021 12:10:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230355AbhH0TJX (ORCPT + 99 others); Fri, 27 Aug 2021 15:09:23 -0400 Received: from smtprelay0032.hostedemail.com ([216.40.44.32]:35074 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230221AbhH0TJW (ORCPT ); Fri, 27 Aug 2021 15:09:22 -0400 Received: from omf09.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 551C7181370A0; Fri, 27 Aug 2021 19:08:32 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA id A022D1E04D5; Fri, 27 Aug 2021 19:08:30 +0000 (UTC) Message-ID: Subject: Re: [PATCH v4] EDAC/mc: Prefer strscpy over strcpy From: Joe Perches To: Borislav Petkov , Len Baker Cc: Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , David Laight , Kees Cook , linux-hardening@vger.kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 27 Aug 2021 12:08:28 -0700 In-Reply-To: References: <20210814075527.5999-1-len.baker@gmx.com> <20210824090338.GB7999@titan> <20210827173633.GA3040@titan> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.94 X-Stat-Signature: rnq8dik9jk6dm8eigjyka9wd7ha9tycw X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: A022D1E04D5 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX199FhWeVlOO1aX/0GGpp0KsHw50NmpmSZk= X-HE-Tag: 1630091310-308896 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-08-27 at 19:54 +0200, Borislav Petkov wrote: > So it would be a lot more robust if something would catch that change, > albeit seemingly redundant now. I still think scnprintf is _way_ more common and intelligible as a construct than this odd strscpy with required error checking.