Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     beanhuo@micron.com, linux-scsi@vger.kernel.org,
        cang@codeaurora.org, linux-kernel@vger.kernel.org,
        Daejun Park <daejun7.park@samsung.com>, avri.altman@wdc.com,
        Keoseong Park <keosung.park@samsung.com>, jejb@linux.ibm.com,
        ALIM AKHTAR <alim.akhtar@samsung.com>
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v2] scsi: ufs: ufshpb: Fix possible memory leak
Date:   Fri, 27 Aug 2021 22:32:07 -0400
Message-Id: <163011776501.12104.14931866773646198562.b4-ty@oracle.com>
In-Reply-To: <1891546521.01629711601304.JavaMail.epsvc@epcpadp3>
References: <CGME20210823090714epcms2p1e414fdd91582bdbf8170b4cefb8a0f74@epcms2p1> <1891546521.01629711601304.JavaMail.epsvc@epcpadp3>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.mkp.ca.oracle.com (138.3.201.9) by BY5PR17CA0025.namprd17.prod.outlook.com (2603:10b6:a03:1b8::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Sat, 28 Aug 2021 02:32:26 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 42f886a0-4c7b-4c63-a968-08d969cc13e5
X-MS-TrafficTypeDiagnostic: PH0PR10MB5515:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB55152EE0C778DB9DCD7EC6BC8EC99@PH0PR10MB5515.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: k46DrrG26lwNumIBl0xaiQLvRk8RuXjXoO89CWkvtJC72d/f4H9ouIzcOU/wGjZUhKSdPgjqC00bDhE0Uf4DUvOjMjtgT/K7Zrxe6HXW5nkp0hfjjsKbUZNcIDqWFQIRco1X7PRNmpnIcYAYZP1/lebfRn8pIilini3BRaE0pocbT+fSYZLsCrJDVY/Q7//blmH3IJSknfVeURVmLzgy35Lj8WR/6F+vnz8FY77ytGief96cYzqOzZlHleptIwe32rLq4Pn536WXbGOQxchYcSiIxcEK8ZGH4OVMVK9Xt4E8QAUpBRaLFtvcfJT2nHPliVVkDvD8LCjwDpaNWgzBd+T/RUQyGKTxIYGpnel07UeyZcwRCfnivnuSsY+RL1SPRuo70ktACQ5w+n6vARvlgmtRQLCs1R3dXwHBJP7Bo7C0ZrdUlV071rXL3vaP/50l/UuRzORIrpPpbL+yOdlfkE6pjYSlQikAPZ2lKFxD4TfD/BywdeTwor+mHc4mTzDCS/vMMpJGnL3cmpLhEE3gSShQmmMu0EKsNuwQEVl6ZXVlLlHfBdb7HsFsrZnk3xjalxqze+rp+5Pw03SEJpyDfySx9H8sCg2eUJOJt0AwQasDKhqCD7wlkwiyDYSxEQmVf8gVDUovvbD+7OcUTqhGWb+0TJIjwBJ0KS0pkAeZ4M1WVvhyTcFc68WYsnAA/B4zWppYZQEdPbZ+sZtrbbED4jJvXGLWVnv782gpfqcoYkpEsmZxcEIfYiFF9YqBsTIxDZizLQuy9gahlpmb/5BUFQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6666004)(966005)(5660300002)(2906002)(508600001)(52116002)(38350700002)(38100700002)(4326008)(110136005)(7696005)(316002)(36756003)(186003)(956004)(2616005)(6486002)(26005)(8936002)(66556008)(4744005)(107886003)(103116003)(66476007)(66946007)(8676002)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHJBa24ySjA5OS8zTUtlR1o4L2ZBMGlTQVoxNEx5M0VKMUE4VW1ETURsU1hS?=
 =?utf-8?B?QmdtM3VMSENXTEo2ckJpOXdJRnlFQU5YcElRbnQxNG9FOXJ3Z1d0VTVzeTFr?=
 =?utf-8?B?TkJMZ0h5ZVVUODRybXJDMmovTHljZHpGQ2phcmZNTVJpOFNEYmxiVGwvcVIy?=
 =?utf-8?B?aFdHY0QrY281S0ZNaDJCYlpYVzlXdGwrdENUTkorNUlFTzZNYjJuQUFDcWpE?=
 =?utf-8?B?WEdnRkZhUlVGWnZyNU94amdoZkR0S2NBRzh1QjRsYWF4dTJydnVrTHFRRFM5?=
 =?utf-8?B?RE9QSStXckE3QnRHSG9lRjQyTldicUY2SThzSS9xSDFCcGx1L0E2ckJFYTlD?=
 =?utf-8?B?UW9jNVVnd3ZscFhoRlQ1Mm9leVkxOUhHSlVET3RrYlJwS1IwczZzNHJSVFBG?=
 =?utf-8?B?alQ1bVJWTDNFSStQaCtDRlZtMXVnbXNQdnhsemNZOTlOaDJrVXE0anNYd0wy?=
 =?utf-8?B?eksyUUJBTUtVOW5KejFxMzluRzNJRXVSRkJqQVJDb2p5Q1lYNVBuSngwd1h1?=
 =?utf-8?B?eDZaTkllT2ExN1M4cXBmTVJycDIwZWpOWDVEZ203RERzVWlqL3BvaDlIeFlU?=
 =?utf-8?B?THMyengvalgyZEFONkpCdUp2eGlWbVRPdVFWVUhDYTdib3NTTUlSZXhsUUNC?=
 =?utf-8?B?ckJhQnI2QmlqTGNXbUdUZ3FoaU9Sd2c4dVcyZkliZG00MUVXNHZoUUlHRUhr?=
 =?utf-8?B?YXpOajdSdWNFSTBjSTlyajlvUHlab0xobVhpcnhJb1B5bVFuamxHclo4M2hH?=
 =?utf-8?B?T3RJcnhUcVU5Y2IzYW1BVU9vY0hWcWNBUW0zNU00Nm56WEFlVld2RCs3aE11?=
 =?utf-8?B?bUFOQ1pseFRXMFkzcGUvRzNuMjhhaEErZzdzczJXWUV6SGVIM3pMYzVmMGFW?=
 =?utf-8?B?cVUwLy96Y0RJM1p1Y0FDZ3FQb0xRdllFaTNNbmtUbFNURWdoVDNtRm5FRGFm?=
 =?utf-8?B?cit5aUtEZzY5YkxsSGZ0eUs5TFl1NVVIMGJKMUJnRzk2YzFnSHVMVWhHUHJF?=
 =?utf-8?B?cGhZaE05anQyaDIrYjVpVG9DUmtwRXVWeUxWZjV5V25FTTkxWTdWM2tRWXVa?=
 =?utf-8?B?UnZkekxSNG43RjdtUkpkaG04WHhCbG51SVFCTmtNblJjVDJYRXFqNUF6ZG9K?=
 =?utf-8?B?UnlnTk9JZ054QU1JWE9rWktpS0p5MDR4T3ZzMHVGN0xNUEEwNFRCUGZSaUxr?=
 =?utf-8?B?ZVNtQ0RheHhwQk1QQ2dmdUJIQzNUZGtiQWFGTDVUb1RDT0tkK2xMTUUwT2pF?=
 =?utf-8?B?M1JMdUtHQWt2Sm5JVGV2OWpRVVl6L1d2K2xUVGNVb3JydU0xNjFyb0JXaXVP?=
 =?utf-8?B?UHFjcjdzZ2tHOGxwOUdsYW1DeUZLd20rQUJUWStCS2FPNDJhemxkQWRTRElH?=
 =?utf-8?B?eE5TTDJVV2ZGS2FYbWpncGVzdWZCTVlsZUlxM3laNHhLbTBDT3FMdUMvdzlw?=
 =?utf-8?B?RWg0ZHlsN1VtK0p5YmJJL2g3RDkxS0xUcm1idkwvYUhHc1dTb2lVb053R2pC?=
 =?utf-8?B?enBlZGtuWm9zSU5KNFdXdm5veXg2djJ0QzA2VlhjaDVNWmtpMjdNcDZsTXJl?=
 =?utf-8?B?anFkY28xcitiVHQzQWdkbmZzWXFQS290L0NwWHExNWlXdGk0a1VvZ21jWWRr?=
 =?utf-8?B?UWdQSmRVSkkySmtWY2ZWVjhkakl0anNwSVhKbmExa3JrVmVCbXdWdmJMZ2Nv?=
 =?utf-8?B?VnVyRCtzdExsME9GZ3ZGVDFpUk9OM3gxNTE5VlRVQkdvZm9XYms2S1h0d3ZG?=
 =?utf-8?Q?/2bshoykjNFcisV4Fnzl6+UEDlsVSQOAe14KroN?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42f886a0-4c7b-4c63-a968-08d969cc13e5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2021 02:32:28.0217
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4nx+5CvMxhh0h0eWkVMt3uUSF3EVgyr/Qcfdlm51Djl/bmfg/wv8brM4fv6QO+GAe5gPXuO17j3vhHsk+Qc7kLnNu+X1NBN5brx0G/EUQuE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5515
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10089 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0
 adultscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108280012
X-Proofpoint-GUID: QqQT_8EKTd2WqYf1RseKrzxEbm4uXfoQ
X-Proofpoint-ORIG-GUID: QqQT_8EKTd2WqYf1RseKrzxEbm4uXfoQ
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 23 Aug 2021 18:07:14 +0900, Keoseong Park wrote:

> When HPB pinned region exists and mctx allocation for this region fails,
> memory leak is possible because memory is not released for the subregion
> table of the current region.
> 
> So, change to free memory for the subregion table of the current region.
> 
> 
> [...]

Applied to 5.15/scsi-queue, thanks!

[1/1] scsi: ufs: ufshpb: Fix possible memory leak
      https://git.kernel.org/mkp/scsi/c/6c9783e6296e

-- 
Martin K. Petersen	Oracle Linux Engineering