Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1916412pxb; Fri, 27 Aug 2021 22:29:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCDzFMDCJm7S7zkCSnoxoa739UNKRcBSh6yIezb4NjDDT1rJGCnx0i52BjOr0mexVfsSlW X-Received: by 2002:a17:906:12c6:: with SMTP id l6mr14237230ejb.373.1630128581077; Fri, 27 Aug 2021 22:29:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630128581; cv=none; d=google.com; s=arc-20160816; b=mQorWJMTMeEYFrMuqrmbYVe5z5IldtFHsQW0T4wXsHoodaqnovvR1RvqH2zEiEiSTn DeCdj78yAgxuwi1gA45kA6mkdsd+5CeUm25bhRLW+yuGIQA+wdSMpADL9lnssH+lH7vd U1SnIc4dQitJAJrsBkEx/vDNWebD2SUY88h/R5GxCT4OpR7N1XeDf/KirupZMybRe6ou E8A0dQSvOjQzdJ3WbDcMwqsNOXu3MyVG4v+CSLpmyrc7rm4PcY0udwnadh2zcgGzzR2s fDC0c1/6ys9LILJYzsvN91dQvThW4EwqrbUmrNL8IKlVPzFwcaA7GYQFKByeQ0hP1jEK +P6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=2JfUpe2H37PEi8fU0OKJL2trjpNhW7D/OwMqmglIVHg=; b=pp8ZYweBAPs3TBjj2yZD+ksN8unsg4vSrbpoopH/ArWfQSVBhzA6x+MwdAmUGkMm21 uGVGuGR2evLQF7zkXgBfEz7GQcqxe+rzZX1Xq2t9DEij6WeWLjejszKzqR02PDilerp3 McbPsFdH91xRhn5usUKPcrTgrcDT0AXkAttlKobMEfIq+x6/GBpkLk1jJ4vgRoVko5vO SwuyTcsRRjQdzrrWCX6312GAIZgQA9Jlu7W/ixpzOqeqDUxBVF8OHz1QK0VVaeU99xQW yhxc6J4lwR6ZGfQNScX31MEZMjGsP7QXBhuyLVlXp3xvwP7VjKu3Nrdc9xhh+svsytl+ ZHrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=wmdEvv2E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id aq21si9091987ejc.637.2021.08.27.22.28.42; Fri, 27 Aug 2021 22:29:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=wmdEvv2E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232702AbhH1F0y (ORCPT + 99 others); Sat, 28 Aug 2021 01:26:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232255AbhH1F0x (ORCPT ); Sat, 28 Aug 2021 01:26:53 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11D85C0613D9 for ; Fri, 27 Aug 2021 22:26:04 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id fz10so6091738pjb.0 for ; Fri, 27 Aug 2021 22:26:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2JfUpe2H37PEi8fU0OKJL2trjpNhW7D/OwMqmglIVHg=; b=wmdEvv2ENIhYYGUB7JTLAaIAv0cY9J3AEXqGcxs1JW+wpuG+n6GX/zaphPuMCLN3xI ns9idB6Sg7OOr03SuAxG8sRfuinLdHFSjEU7Jq3tp6oLpTSXdhzJPqGFq/uZ+786OV8p xd/s6r1r4ESyAYa+7j4DekrjGfL2n2mT9Ovr+H0dMEBLRaDX5FUtiImrzjnlHt2guhE4 SttN5jwQ2wwEd3jfeAACvoIdQHjZHFJkMFIJcbCmI+cJx+9Z5ebldao2y6R7yv1o1Gnl WYYQWav3jQ0a7SPEmpucjj3+iuyqLjSHpDbeiKtEJylvNGStg8w9l95tdLZctBgLKoTg DR+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2JfUpe2H37PEi8fU0OKJL2trjpNhW7D/OwMqmglIVHg=; b=bPUZyudamuO21vy1WY0oiczbqcnazqyvahNtEpZ3MA1Aid8tZnUTbgipoXYHpnCfFX UJo2cTgGuTjjN56OclzWembwpsg00/dPOWWSxU7N9baz5jqBA4XrCpsN8d+k8gBFWTaL AUgTzQbin7+lc6DbzM8Q9eCyzZ7RZ7d+zxeGixklgP2Wo7USeOUc4sXK+fb4oS4gQLAn UjaAhwKR9Hx+C7aHfiaJ4AHXsqSNGWvg/Me7wdWK7jqwTis76ochbgrUWBEWLwC4kwf+ hOL8e3w5cMSsOXvu2THdcTMCTMCpyw4MvLjK66PfnJrp0ClnvvRDg6gFP67lsNL/a2gl LoyQ== X-Gm-Message-State: AOAM533LgmdtlPfPz+71rc3MW9QVuQbTtxKR4IVpZ8zQGCAWkrRwKJmM 9wktscjuJgGv6OkFEoe9DKpxVnc98hQdA7161usuuA== X-Received: by 2002:a17:90a:5405:: with SMTP id z5mr14659897pjh.229.1630128363484; Fri, 27 Aug 2021 22:26:03 -0700 (PDT) MIME-Version: 1.0 References: <20210828042306.42886-1-zhengqi.arch@bytedance.com> <20210828042306.42886-2-zhengqi.arch@bytedance.com> In-Reply-To: <20210828042306.42886-2-zhengqi.arch@bytedance.com> From: Muchun Song Date: Sat, 28 Aug 2021 13:25:27 +0800 Message-ID: Subject: Re: [PATCH v1 1/2] mm: introduce pmd_install() helper To: Qi Zheng Cc: Andrew Morton , Thomas Gleixner , Johannes Weiner , Michal Hocko , Vladimir Davydov , "Kirill A. Shutemov" , mika.penttila@nextfour.com, David Hildenbrand , linux-doc@vger.kernel.org, LKML , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 28, 2021 at 12:23 PM Qi Zheng wrote: > > Currently we have three times the same few lines repeated in the > code. Deduplicate them by newly introduced pmd_install() helper. > > Signed-off-by: Qi Zheng > Reviewed-by: David Hildenbrand Reviewed-by: Muchun Song