Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1 2/2] mailbox: qcom: Add support for sm4125 sm6115 APCS
 IPC
To:     Nicolas Dechesne <nicolas.dechesne@linaro.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Sivaprakash Murugesan <sivaprak@codeaurora.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, phone-devel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht
References: <20210622203759.566716-1-iskren.chernev@gmail.com>
 <20210622203759.566716-2-iskren.chernev@gmail.com>
 <CAP71WjxRpdoN9MMTH2Y2Xgc==tC2jWfm7X0_A1CrzZ40N_rg8Q@mail.gmail.com>
From:   Iskren Chernev <iskren.chernev@gmail.com>
Message-ID: <1085ae56-f164-27e3-0c00-f6b187eed1b3@gmail.com>
Date:   Sat, 28 Aug 2021 09:21:58 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <CAP71WjxRpdoN9MMTH2Y2Xgc==tC2jWfm7X0_A1CrzZ40N_rg8Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/27/21 6:42 PM, Nicolas Dechesne wrote:
> On Tue, Jun 22, 2021 at 10:38 PM Iskren Chernev
> <iskren.chernev@gmail.com> wrote:
>>
>> SM4125 and SM6115, codename bengal, have APCS mailbox setup similar to
>> msm8998 and msm8916.
> 
> subject and commit refer to SM4125/SM6115, but the diff below is about
> 4250/6115. I suppose it's a typo here, since 6115 is similar to 4250,
> not 4125, right?

Yes, you're correct. The issue was resolved in v2 submitted shorty after:

https://lkml.org/lkml/2021/6/27/167

>>
>> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
>> ---
>>  drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> index f25324d03842..1a4d8cca5881 100644
>> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> @@ -166,6 +166,8 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = {
>>         { .compatible = "qcom,sc8180x-apss-shared", .data = &apps_shared_apcs_data },
>>         { .compatible = "qcom,sdm660-apcs-hmss-global", .data = &sdm660_apcs_data },
>>         { .compatible = "qcom,sdm845-apss-shared", .data = &apps_shared_apcs_data },
>> +       { .compatible = "qcom,sm4250-apcs-hmss-global", .data = &sdm660_apcs_data },
>> +       { .compatible = "qcom,sm6115-apcs-hmss-global", .data = &sdm660_apcs_data },
>>         { .compatible = "qcom,sm8150-apss-shared", .data = &apps_shared_apcs_data },
>>         { .compatible = "qcom,sdx55-apcs-gcc", .data = &sdx55_apcs_data },
>>         {}
>> --
>> 2.31.1
>>