Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2042845pxb; Sat, 28 Aug 2021 02:44:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUl4Qt98jBjMN5pL9o041twCGZnKeGVQhN83weAbmDe88pZLj20mEf802QTPhqqv8HIT7w X-Received: by 2002:a6b:e712:: with SMTP id b18mr10823032ioh.186.1630143899439; Sat, 28 Aug 2021 02:44:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630143899; cv=none; d=google.com; s=arc-20160816; b=vrCBBh3Ih+UCOKU87vCYo7AA42yNpzGPZ2YebraOUOzfxyhobch3hnOj7GTz2D1a+S kvwQQkIvdqfGJVmmuF+4ld3S2IocxwrwWFyISvkCGydNDQ2Zo1QOHXEHg8+mENM1Ul3a sTGs0V6kWzdUz1GN39qt87aBSpAoEAxMs+cZDGHx7lnaZf3KlKDnUHCK/f808gLIrCOD Y38GW3r15VWzF+Q23/z3As9TE97/vSuZpurx88ps+WZdyOLdNv0d8CNGW4tT13BxGYA8 kLlwVSeiO6RoV00chfc7SlXE8KUsMqYnNpELH+lPUBfNTua1av+bds6/LeAle5HPwh3d cU1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WEBhbbmUqQPemp5592Sf65tTKA72i6T8Muei3+/rnRk=; b=Tv/DFR0S+be+whUIIiak3VSakOvEc6bntHBOJZaIPhk5ITDLeYpBjedBQZkfO4yXPj xp/c16r2dh/AmRI2CP46lFSDoi/rgVJMoT1eDkCIp7c4qS9eE6d6ky5BE022FaXbNKWd 4fn85Va8xu87RUEBhU7ilTOUwRFlhPrN/z0qRFCM3H9nW23bdo/Fh/Bj8Z+qt8T54duV /mrhxj62SSYoQPgLFXNnI4F5ZaLeW+Xvmjv/EHSthYE7k5O0/yzOjIMvmhioByDiR/Zi i3HPALMwWg6JJzuCk8mY+UIlCyeHMTp0PraKHNvPXp4xpW/d42DytGaMGLRms4C2nUPZ bPbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=f2oQMK+B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j9si8566620ilr.97.2021.08.28.02.44.47; Sat, 28 Aug 2021 02:44:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=f2oQMK+B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233590AbhH1Jo5 (ORCPT + 99 others); Sat, 28 Aug 2021 05:44:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:60726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230444AbhH1Jo4 (ORCPT ); Sat, 28 Aug 2021 05:44:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1E41B6054E; Sat, 28 Aug 2021 09:44:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630143845; bh=x/lg3zgHWReyf3vjQgN74OPkwZEO+XBJFQK5Qu0Hq4g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f2oQMK+BkraDZynJndwwmgcHoSOU5lPVpgcxbE3z4LUejm73dAd37kBkTYZpq6KSd eqWZ6KhEHrOgaCRItYDrZ2ttsoYYPdUznfYlKalOamIhJaCMng7/gONZ+fIIVN2FVj pOVub71Wy6//n5Ueb0PTg/VtQZOE+FgywcHDT9EQ= Date: Sat, 28 Aug 2021 11:44:01 +0200 From: Greg KH To: Paulo Miguel Almeida Cc: hello@bryanbrattlof.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: pi433: fix docs typos and references to previous struct names Message-ID: References: <20210828000836.GA10188@localhost.localdomain> <20210828092757.GA3773@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210828092757.GA3773@localhost.localdomain> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 28, 2021 at 09:27:57PM +1200, Paulo Miguel Almeida wrote: > On Sat, Aug 28, 2021 at 08:12:54AM +0200, Greg KH wrote: > > On Sat, Aug 28, 2021 at 12:08:36PM +1200, Paulo Miguel Almeida wrote: > > > In the comments there where some grammar mistakes and references to > > > struct names that have gotten renamed over time but not reflected > > > in the comments. > > > > > > Signed-off-by: Paulo Miguel Almeida > > > --- > > > drivers/staging/pi433/pi433_if.h | 25 ++++++++++++------------- > > > 1 file changed, 12 insertions(+), 13 deletions(-) > > > > > > diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h > > > index d5c1521192c1..1fae62c40661 100644 > > > --- a/drivers/staging/pi433/pi433_if.h > > > +++ b/drivers/staging/pi433/pi433_if.h > > > @@ -5,16 +5,15 @@ > > > * userspace interface for pi433 radio module > > > * > > > * Pi433 is a 433MHz radio module for the Raspberry Pi. > > > - * It is based on the HopeRf Module RFM69CW. Therefore inside of this > > > - * driver, you'll find an abstraction of the rf69 chip. > > > + * It is based on the HopeRf Module RFM69CW. Therefore, inside of this > > > + * driver you'll find an abstraction of the rf69 chip. > > > * > > > - * If needed, this driver could be extended, to also support other > > > - * devices, basing on HopeRfs rf69. > > > + * If needed this driver could also be extended to support other > > > + * devices based on HopeRf rf69 as well as HopeRf modules with a similar > > > + * interface such as RFM69HCW, RFM12, RFM95 and so on. > > > * > > > - * The driver can also be extended, to support other modules of > > > - * HopeRf with a similar interace - e. g. RFM69HCW, RFM12, RFM95, ... > > > * Copyright (C) 2016 Wolf-Entwicklungen > > > - * Marcus Wolf > > > + * Marcus Wolf > > > > Indentation of the name should remain here, right? > > > > thanks, > > > > greg k-h > > you are right, I shouldn't have changed that line. Do you need me to > send another patch without that line or can you ignore just that line > before merging it to your branch? I'm flexible with any approach. It is impossible to just "ignore a single line" in a diff, sorry. Please fix up and resend a new version, remember the work needs to be done by the developer, not the maintainer. Your job is to make it trivial for me to accept your change. Manually having to edit diffs is not scalable at all. thanks, greg k-h