Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <bc0c9cd1-d915-2cb0-ef57-3b9dc5410bbc@gmail.com>
Date:   Sat, 28 Aug 2021 12:19:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.0.1
Subject: Re: [PATCH] staging: r8188eu :os_dep: remove condition with no effect
Content-Language: en-US
To:     Saurav Girepunje <saurav.girepunje@gmail.com>,
        Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, nathan@kernel.org,
        linux-kernel@vger.kernel.org
Cc:     saurav.girepunje@hotmail.com
References: <YSoCfTaR66C6iJFw@user>
From:   Michael Straube <straube.linux@gmail.com>
In-Reply-To: <YSoCfTaR66C6iJFw@user>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/28/21 11:31, Saurav Girepunje wrote:
> Remove the condition with no effect (if == else) in usb_intf.c
> file.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>   drivers/staging/r8188eu/os_dep/usb_intf.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> index bb85ab77fd26..849563b54727 100644
> --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> @@ -496,10 +496,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
>   	struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
>   	int ret = 0;
> 
> -	if (pwrpriv->bInternalAutoSuspend)
> -		ret = 
> -	else
> -		ret = rtw_resume_process(padapter);
> +	ret = rtw_resume_process(padapter);
> +
>   	return ret;
>   }

Thanks for your patch. Perhaps this could be further simplified to:

int ret = rtw_resume_process(padapter);

return ret;

or even:

return rtw_resume_process(padapter);

Best regards,
Michael