Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <YScKYFWlYymgGw3l@anyang-linuxfactory-or-kr>
In-Reply-To: <YScKYFWlYymgGw3l@anyang-linuxfactory-or-kr>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Sat, 28 Aug 2021 18:11:59 +0200
Message-ID: <CAFBinCDLmmtKztpoj5xvhwdagrH_7nJK7qUA+LOg7CWB5eCFRQ@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: meson: sm1: add Ethernet PHY reset line for ODROID-C4/HC4
To:     Dongjin Kim <tobetter@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

Thanks for this patch!

my first suggestion is about the patch subject (first line):
arm64: dts: meson-sm1-odroid: add Ethernet PHY reset for ODROID-C4/HC4

This makes it match the pattern of the most recent commits there:
45d736ab17b4 arm64: dts: meson-sm1-odroid: add 5v regulator gpio
7881df513680 arm64: dts: meson-sm1-odroid: set tf_io regulator gpio as
open source

On Thu, Aug 26, 2021 at 5:29 AM Dongjin Kim <tobetter@gmail.com> wrote:
>
> This patch is to fix an issue that the ethernet link doesn't come up
> when using ip link set down/up:
>    [   11.428114] meson8b-dwmac ff3f0000.ethernet eth0: Link is Down
>    [   14.428595] meson8b-dwmac ff3f0000.ethernet eth0: PHY [0.0:00] driver [RTL8211F Gigabit Ethernet] (irq=31)
>    [   14.428610] meson8b-dwmac ff3f0000.ethernet: Failed to reset the dma
>    [   14.428974] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed
>    [   14.711185] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_open: Hw setup failed
>
> This fix has been referred two commits applied for ODROID-N2 (G12B).
>     commit 658e4129bb81 ("arm64: dts: meson: g12b: odroid-n2: add the Ethernet PHY reset line")
>     commit 1c7412530d5d0 ("arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements")
I am not 100% sure but I think you can just add two "Fixes: ..." tags here
That way this patch is also backported automatically

> Signed-off-by: Dongjin Kim <tobetter@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>