Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935553AbWLFPSy (ORCPT ); Wed, 6 Dec 2006 10:18:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935072AbWLFPSc (ORCPT ); Wed, 6 Dec 2006 10:18:32 -0500 Received: from coyote.holtmann.net ([217.160.111.169]:54972 "EHLO mail.holtmann.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935138AbWLFPST (ORCPT ); Wed, 6 Dec 2006 10:18:19 -0500 Subject: Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core) From: Marcel Holtmann To: Dmitry Torokhov Cc: Jiri Kosina , Li Yu , Greg Kroah Hartman , linux-usb-devel , LKML , Vincent Legoll , "Zephaniah E. Hull" , liyu In-Reply-To: References: <200612061803324532133@gmail.com> <1165415924.2756.63.camel@localhost> Content-Type: text/plain Date: Wed, 06 Dec 2006 16:18:37 +0100 Message-Id: <1165418317.2756.75.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1785 Lines: 45 Hi Dmitry, > > > > I still have the same objection - the "simple'" code will have to be > > > > compiled into the driver instead of being a separate module and > > > > eventyally will lead to a monster-size HID module. We have this issue > > > > with psmouse to a degree but with HID the growth potential is much > > > > bigger IMO. > > > > I guess that this paragraph wasn't for me, but rather for the author of > > the HID Simple Driver proposal, am I right? > > Yes, mainly for him but also for you because we need to be able to do > what Li Yu is trying to do and be able to tweak HID interfaces. > > ... > > > This split is quite painful, as there are many things happening in USB all > > the time, so the best way seem to be just to perform big split (with > > needed changes) at once, and then develop other things on top of it (like > > hidraw). > > Is there any reason why we can't mecanically move everything into > drivers/hid right now? Then Greg could simply forward all patches he > gets for HID your way and you won't have hard time merging your work > with others... I fully agree. Lets move and split the transports now and start the work on top of it. My only concern is to have a clean Git tree to the full history of HID changes stay intact and will trackable. Some quirk decisions and other stuff is not obvious and I assume will never be when it comes to broken HID devices. So do you have pending HID patches. If yes, please sync them with Linus and Jiri can setup a clean tree for the move. Regards Marcel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/