Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 28 Aug 2021 22:47:34 +0300
From:   Kari Argillander <kari.argillander@gmail.com>
To:     Michael Straube <straube.linux@gmail.com>,
        Saurav Girepunje <saurav.girepunje@gmail.com>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
        ross.schm.dev@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove null check before vfree
Message-ID: <20210828194734.7xn3tkdh2yay5yyt@kari-VirtualBox>
References: <YSp4UP1+HrhmDA3C@user>
 <1e31610a-0324-dfb7-abe5-f05d652d461d@gmail.com>
 <b098cbe9-1cc6-d97f-e1d8-df6c99b0afa0@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b098cbe9-1cc6-d97f-e1d8-df6c99b0afa0@gmail.com>
Precedence: bulk

On Sat, Aug 28, 2021 at 09:30:14PM +0200, Michael Straube wrote:
> On 8/28/21 21:20, Michael Straube wrote:
> > On 8/28/21 19:54, Saurav Girepunje wrote:
> > > Remove NULL check. NULL check before freeing function is not needed.
> > > 
> > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > > ---
> > > ? drivers/staging/r8188eu/core/rtw_sta_mgt.c | 4 +---
> > > ? 1 file changed, 1 insertion(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/staging/r8188eu/core/rtw_sta_mgt.c
> > > b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
> > > index f6dffed53a60..4726771a8403 100644
> > > --- a/drivers/staging/r8188eu/core/rtw_sta_mgt.c
> > > +++ b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
> > > @@ -155,9 +155,7 @@ u32??? _rtw_free_sta_priv(struct??? sta_priv
> > > *pstapriv)
> > > ????????? spin_unlock_bh(&pstapriv->sta_hash_lock);
> > > ????????? /*===============================*/
> > > 
> > > -??????? if (pstapriv->pallocated_stainfo_buf)
> > > -??????????? vfree(pstapriv->pallocated_stainfo_buf);
> > > -??????? }
> > > +??????? vfree(pstapriv->pallocated_stainfo_buf);
> > > 
> > > ????? return _SUCCESS;
> > > ? }
> > > -- 
> > > 2.32.0
> > > 
> > 
> > Acked-by: Michael Straube <straube.linux@gmail.com>
> > 
> > Thanks,
> > Michael
> 
> Whoops, I missed that you removed the } that belongs to the enclosing if
> block. Probably because it is not properly indented in the original
> code.

Easy to miss because that bracket is in wrong place in first place.

Michael can you now on even build test before sending. Thanks.

> 
> Best regards,
> Michael
>