Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f6ffc51d-fb39-5191-e2fa-1b3200b89d87@gmail.com>
Date:   Sat, 28 Aug 2021 21:56:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.0.1
Subject: Re: [PATCH] staging: r8188eu: core: remove null check before vfree
Content-Language: en-US
To:     Kari Argillander <kari.argillander@gmail.com>,
        Saurav Girepunje <saurav.girepunje@gmail.com>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
        ross.schm.dev@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
References: <YSp4UP1+HrhmDA3C@user>
 <1e31610a-0324-dfb7-abe5-f05d652d461d@gmail.com>
 <b098cbe9-1cc6-d97f-e1d8-df6c99b0afa0@gmail.com>
 <20210828194734.7xn3tkdh2yay5yyt@kari-VirtualBox>
From:   Michael Straube <straube.linux@gmail.com>
In-Reply-To: <20210828194734.7xn3tkdh2yay5yyt@kari-VirtualBox>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 8/28/21 21:47, Kari Argillander wrote:
> On Sat, Aug 28, 2021 at 09:30:14PM +0200, Michael Straube wrote:
>> On 8/28/21 21:20, Michael Straube wrote:
>>> On 8/28/21 19:54, Saurav Girepunje wrote:
>>>> Remove NULL check. NULL check before freeing function is not needed.
>>>>
>>>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>>>> ---
>>>>    drivers/staging/r8188eu/core/rtw_sta_mgt.c | 4 +---
>>>>    1 file changed, 1 insertion(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/r8188eu/core/rtw_sta_mgt.c
>>>> b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
>>>> index f6dffed53a60..4726771a8403 100644
>>>> --- a/drivers/staging/r8188eu/core/rtw_sta_mgt.c
>>>> +++ b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
>>>> @@ -155,9 +155,7 @@ u32    _rtw_free_sta_priv(struct    sta_priv
>>>> *pstapriv)
>>>>            spin_unlock_bh(&pstapriv->sta_hash_lock);
>>>>            /*===============================*/
>>>>
>>>> -        if (pstapriv->pallocated_stainfo_buf)
>>>> -            vfree(pstapriv->pallocated_stainfo_buf);
>>>> -        }
>>>> +        vfree(pstapriv->pallocated_stainfo_buf);
>>>>
>>>>        return _SUCCESS;
>>>>    }
>>>> -- 
>>>> 2.32.0
>>>>
>>>
>>> Acked-by: Michael Straube <straube.linux@gmail.com>
>>>
>>> Thanks,
>>> Michael
>>
>> Whoops, I missed that you removed the } that belongs to the enclosing if
>> block. Probably because it is not properly indented in the original
>> code.
> 
> Easy to miss because that bracket is in wrong place in first place.
> 
> Michael can you now on even build test before sending. Thanks.
> 

Sure, I usually do. For this one I did not but obviously I should have..
;)