Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2716677pxb; Sun, 29 Aug 2021 01:13:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNkuy5L0JV01OhTx7c7HIkPP1QR8dtJLlEZDLb4h6nbJG1EPWmao3c9trIKSip5X+zQWiP X-Received: by 2002:a17:906:184e:: with SMTP id w14mr18704666eje.526.1630224817868; Sun, 29 Aug 2021 01:13:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630224817; cv=none; d=google.com; s=arc-20160816; b=vjZysEKnM12WL6fB7UTGb6Xp+MJpbu/RibijNqzj7J9UNwExYc1+1IvNl1s9mtQVTG avBZqvhUYHBTF7482U8cMGfOOQGzLewuQyhhQcy+VIpr/98mgO5hQCKOQj6B83k7SKB4 aKB8Y2P4J3FLXzRCDx+tGZKhzhQqGMoqImkSouZ0OjkAYTHRJ5CFVb85XyBWImMxrKoA G0MALjyzLyUkOmrs65O1eZcVUVHBQu1pnyCSRZBqxd0PFzppVo7OAvNVKAcOW/oOOYVE OAhRhTk00xXSlyYOh9LxnaC1SYTYErdmkzBxJH1BlrduNWA3fAhMYJV+lqTSnMNOCg5s prjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fdJfM9YiCEwD9WwnL8NMnJ11YxNnA5GrgNQoqDEr3c8=; b=mHWIO9LKLDKk/Pn6q2Fzdl+A+ar2BKI+Q/0eWfLZyMbZ/V9XEuRVsEFo/cOUozpCRD KGw6e4PaZk0r96EWusAwst4UzZIkajNkanioQI1m/QjZeMfM3T7QC2DHTqD1OsW0jaAP Z/bRGe5cxEaH4KILJjBC0saArkOfvsuKFpwYPkMbLno2En3EUd0A7he3l1Nt3xn1/FCZ 94Dpp/PiJCOXdWU2vBZIYag5sfRlQoiltrEdLGGKj69IG44WGn3tARjek9/vg9gOcudT u0qlMEO+LJH6SaJ9Fi3uBmxJVnFdrUGEKikJnoUhLDJ/1IwKz2QCusQe1o0ie7/KLyNV W+gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XTMOJ1BP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z5si10666298eja.692.2021.08.29.01.13.00; Sun, 29 Aug 2021 01:13:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XTMOJ1BP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234781AbhH2ILg (ORCPT + 99 others); Sun, 29 Aug 2021 04:11:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:54194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232155AbhH2ILe (ORCPT ); Sun, 29 Aug 2021 04:11:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9424C608FB; Sun, 29 Aug 2021 08:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630224643; bh=9rYyvMODTtObBSqfSrojxx5ZQ0pfDpovtGm0HkyPW+w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XTMOJ1BPPUlIrSn2F8oIoxKLOdios+4mn8o9NzIbO4jTn2M7EVvPyN3axtkf2tsyl GuUIKwIb4mFGDK73Kxc9dyYdIwiWj0JcF2207IKV/SXLJagOg0xp1HjUktx5OVO5Bh oekl86pa23iMYDXd2i6H5hHeDlRB266LjAYBLIhc= Date: Sun, 29 Aug 2021 10:10:33 +0200 From: Greg KH To: Saurav Girepunje Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, ross.schm.dev@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com Subject: Re: [PATCH v3] staging: r8188eu: core: remove null check before vfree Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 29, 2021 at 01:04:22PM +0530, Saurav Girepunje wrote: > Remove NULL check. NULL check before freeing function is not needed. > Correct the indentation. > > ChangeLog V3: > -Added change log. > > ChangeLog V2: > -Correct the indentation. Please put this information below the --- line, as the documentation says to do. thanks, greg k-h