Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936131AbWLFP5u (ORCPT ); Wed, 6 Dec 2006 10:57:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S936127AbWLFP5u (ORCPT ); Wed, 6 Dec 2006 10:57:50 -0500 Received: from smtp.osdl.org ([65.172.181.25]:36531 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936100AbWLFP5t (ORCPT ); Wed, 6 Dec 2006 10:57:49 -0500 Date: Wed, 6 Dec 2006 07:57:29 -0800 From: Andrew Morton To: "Maciej W. Rozycki" Cc: Roland Dreier , Andy Fleming , Ben Collins , linux-kernel@vger.kernel.org, Linus Torvalds , Jeff Garzik Subject: Re: [PATCH] Export current_is_keventd() for libphy Message-Id: <20061206075729.b2b6aa52.akpm@osdl.org> In-Reply-To: References: <1165125055.5320.14.camel@gullible> <20061203011625.60268114.akpm@osdl.org> <20061205123958.497a7bd6.akpm@osdl.org> <6FD5FD7A-4CC2-481A-BC87-B869F045B347@freescale.com> <20061205132643.d16db23b.akpm@osdl.org> <20061205135753.9c3844f8.akpm@osdl.org> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 842 Lines: 19 On Wed, 6 Dec 2006 15:25:22 +0000 (GMT) "Maciej W. Rozycki" wrote: > > Maybe the lesson here is that flush_scheduled_work() is a bad function. > > It should really be flush_this_work(struct work_struct *w). That is in > > fact what approximately 100% of the flush_scheduled_work() callers actually > > want to do. > > There may be cases where flush_scheduled_work() is indeed needed, but > likely outside drivers, and I agree such a specific call would be useful > and work here. I think so too. But it would be imprudent to hang around waiting for me to write it :( - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/