Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2835973pxb; Sun, 29 Aug 2021 05:14:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQzpYhUzqg+ZEXv9EHfNdCbvOXd7oBxfEJcbs7FOXSPW18H7lDNufaO+6CiPDFIbxm8jrv X-Received: by 2002:a17:906:840f:: with SMTP id n15mr20095117ejx.460.1630239295974; Sun, 29 Aug 2021 05:14:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630239295; cv=none; d=google.com; s=arc-20160816; b=XuQCiY/uNnngozmGWeztCYTra7CMcb36g1iUeRqfeqXAWlwE1cs1gPh9aGV2dh4Ish sDh/2L9eA0zrfTfDcuyE0hZwvuFJj8MWe3W3q75qDdcwBF+eYDEFjpx2qPFcWi1LPUQM j9y08Asdtdk9cfvo4aobtIGuEAaP1k4ULWC4UBytYXcy2Y/9KHGMfsavW9aWTadbjO7H BIlXjFvJsxG90PqsmbwdQwyGZqQdtHeV263ZLOeHA7UxHJWne0I/pPNS+yd69Q6KhMq7 Ucw8AMlemIyvqWNqeNiwP997In2xrFWV9zyvEdiKqiz+bwnD2zcZRsJK6aAPXQ/t3sto WNdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=o+swTcS+LZnxIermaKa3LHQgsSD1cR5lC/MsDCKUum4=; b=PhgHDG91QXaRTQgbqjB8XhKSZWOp67eAgWbZFthYBrI44yhTRzHIef7Euj9FSapyH6 dRWc75jq92oC6z6HWxdBjhLTfoUM44a7gdD1uZhcDf9PwgiKnGUGt3nqQgH3bM/rI+cM b0PENWv4AioxDa8N0IyWNsySNofBo6iQVx7Af10FHLPMFCUfmduHLfV4+YDmfulz7lk8 jBwhTAc2tKrFrnhO/lxnqnFbG54p2hUVh2q9sFyLxKRUrdcvfRUK1z5AtwbpLLEmCScC +I7MYIkKE+gBFX0eOSEaDNr9VM7sFwCBNLWW2nqMS8sQlbajybN75d/bBpdPqPh3GaXh hJiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="aYxv1Rj/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v11si14864267ejf.623.2021.08.29.05.14.20; Sun, 29 Aug 2021 05:14:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="aYxv1Rj/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235290AbhH2MJU (ORCPT + 99 others); Sun, 29 Aug 2021 08:09:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235182AbhH2MJT (ORCPT ); Sun, 29 Aug 2021 08:09:19 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46D84C061575 for ; Sun, 29 Aug 2021 05:08:27 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id q21so20483396ljj.6 for ; Sun, 29 Aug 2021 05:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=o+swTcS+LZnxIermaKa3LHQgsSD1cR5lC/MsDCKUum4=; b=aYxv1Rj/ABPzkGnAcW5pKXkr02VN5YLA0N/YNOj601SA4oIHrGQ+PeajV0okIaQpSR TihF223KlVKNF7nwT5nDMa4C/umw81xwM+tRuCIkufYXl/Q2JaeP6MpCt3Bi+DLLipEU gEcTUYOzsXn1k2JgkJdt4pkDeEZzBOBQ/9mylCwbAQdKQ+PetXdbsMDfNCE8z6kCOv01 93Qc5qHnz2BEqBsDMkBp2uWHKdGbQJJ1OoQc+5wpQqWYNKs077zZqyyjlJEAoBo+xmAB bHdxf7UldqVjntC8J01XMrnUOFP6fHExWT2rN6YDZqZEbStV/QWpnfZAqN0ETH4Ncg8e JAuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o+swTcS+LZnxIermaKa3LHQgsSD1cR5lC/MsDCKUum4=; b=URweCRMwDiGin9s0Cy9dHdfCk+8jVBKkzjSWpoGFLSw2u2jVYjuVrReeG5Jg8XT7JL hWT3KCMgPBB7clJAeetBRROcvKkTa7/9cUYbDPdIQdLWsMoRA+kcp/UxdRMUtrMZw3SZ XUQRwf6vkmJ0t2HGL9OWuH3Z3BYNIVuWreS2dY4VE0vaLSDWk8DxGO8rnY6YItyjS/nZ X3E6S9kg/OJ0McIQfaE11lHwa/y9wwxltswIMXY+B9hwaKUrB6Tr99P69ByrMiO+BMPk EeSF9nD650AbpU5Iy8ATmZMBonqGgyak44IV+yUhQosWJNsdlo+wEm6cLPCmCabhFhmB u/9A== X-Gm-Message-State: AOAM530RqorrqkEn0vicpuK/YcT/jjg7EehTQJoJf7GrQqpJcsAUFQlS QqLFC6YsqGhndvgV/hHQ9II= X-Received: by 2002:a2e:9b14:: with SMTP id u20mr16102304lji.21.1630238905641; Sun, 29 Aug 2021 05:08:25 -0700 (PDT) Received: from [192.168.1.11] ([94.103.229.213]) by smtp.gmail.com with ESMTPSA id a3sm1421362ljj.122.2021.08.29.05.08.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Aug 2021 05:08:25 -0700 (PDT) Subject: Re: [PATCH] staging: r8188eu: core: remove condition with no effect To: Saurav Girepunje , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com References: From: Pavel Skripkin Message-ID: <904b3dc8-fa52-a410-c9d2-f6a1d85487fc@gmail.com> Date: Sun, 29 Aug 2021 15:08:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/29/21 12:01 PM, Saurav Girepunje wrote: > Remove the condition with no effect (if == else) and group multiple > cases which execute same statement in rtw_mlme_ext.c > > Signed-off-by: Saurav Girepunje Reviewed-by: Pavel Skripkin